- 15 Sep, 2009 40 commits
-
-
Greg Kroah-Hartman authored
Come on people, it doesn't get simpler than this, why have a typedef for something so tiny... Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by:Greg Kroah-Hartman <gregkh@suse.de>
-
Greg Kroah-Hartman authored
function pointer typedefs are allowed in the kernel, but only if they make sense, which they really do not here, as they are not passed around with any kind of frequency. So just spell them all out, it makes the code smaller and easier to understand overall. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
function pointer typedefs are allowed in the kernel, but only if they make sense, which they really do not here, as they are not passed around with any kind of frequency. So just spell them all out, it makes the code smaller and easier to understand overall. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
function pointer typedefs are allowed in the kernel, but only if they make sense, which they really do not here, as they are not passed around with any kind of frequency. So just spell them all out, it makes the code smaller and easier to understand overall. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
The Linux kernel doesn't have all caps structures, we don't like to shout at our programmers, it makes them grumpy. Instead, we like to sooth them with small, rounded letters, which puts them in a nice, compliant mood, and makes them more productive and happier, allowing them more fufilling lives overall. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Still a lot of long lines, but that's nothing I can fix up at this time Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
It's much better now. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Where's the hazard pay for cleaning up this mess... Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Almost clean. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
All device release functions need to do something, if not, it's a bug. By merely providing an "empty" release function, it gets the kernel to shut up, but that's not solving the problem at all. Stick a big fat WARN_ON(1); in there to get people's attention. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
All clean now. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
There are still some very long lines, someone needs to unwind the logic there to resolve that. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
This gets rid of all of the forward declarations. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Some one owes me a lot of beer, or a nice bottle of rum for all of this crud cleanup... Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Add List.h and RingBuffer.h removal items. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
This gets rid of the unneeded typedef and the forward declarations, saving a bit of code file size. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
There are still some too-long lines here, hopefully they will get resolved later. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Saves space by getting rid of the forward declarations. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
There are still some horrible long lines in here, which some simple code reworking will make smaller and easier to understand. Also note the FIXME in struct netvsc_driver_context... Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Lots of cleanups. Note, the use of volatile still needs to be resolved, and possibly the #ifdef could be done a bit "better". Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Reorder some functions to get rid of all of the forward declarations. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
It's now much nicer and cleaner. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Everything is clean except for some very long lines that need a bit more code rework to resolve. That will have to be done by someone that can test the code. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
It's only ever used within the ChannelMgmt.h file, so pull it into there. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
Move it out of the include subdirectory. No code changes here, just file movements. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
It's all clean now. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
No typedef changes yet though. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by: -
Greg Kroah-Hartman authored
It's all clean now. Cc: Hank Janssen <hjanssen@microsoft.com> Signed-off-by:
-
