- 26 Feb, 2019 16 commits
-
-
Tetsuo Handa authored
ashmem_pin() is calling range_shrink() without checking whether range_alloc() succeeded. Also, doing memory allocation with ashmem_mutex held should be avoided because ashmem_shrink_scan() tries to hold it. Therefore, move memory allocation for range_alloc() to ashmem_pin_unpin() and make range_alloc() not to fail. This patch is mostly meant for backporting purpose for fuzz testing on stable/distributor kernels, for there is a plan to remove this code in near future. Signed-off-by:
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: stable@vger.kernel.org Reviewed-by:
Joel Fernandes <joel@joelfernandes.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Bo YU authored
Fix sparse warning: drivers/staging/wilc1000/host_interface.c:450:30: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/host_interface.c:450:30: expected restricted __le16 [usertype] beacon_period drivers/staging/wilc1000/host_interface.c:450:30: got unsigned short [usertype] beacon_interval drivers/staging/wilc1000/host_interface.c:451:25: warning: incorrect type in assignment (different base types) drivers/staging/wilc1000/host_interface.c:451:25: expected restricted __le16 [usertype] cap_info drivers/staging/wilc1000/host_interface.c:451:25: got unsigned short [usertype] capability Signed-off-by:
Bo YU <tsu.yubo@gmail.com> Reviewed-by:
Ajay Singh <ajay.kathat@microchip.com> Signed-off-by:
-
Bhanusree Pola authored
Clean checkpatch.pl issue in various files: CHECK: Alignment should match open parenthesis Adjust parameters to match alignment with open paranthesis Signed-off-by:
Bhanusree Pola <bhanusreemahesh@gmail.com> Signed-off-by:
-
Bhanusree Pola authored
Remove blank line to resolve checkpatch.pl issue: CHECK: Blank lines aren't necessary before a close brace '}' Signed-off-by:
-
Bhanusree Pola authored
Remove unnecessary blank line issue found with checkpatch.pl: CHECK: Please don't use multiple blank lines Signed-off-by:
-
Bhanusree Pola authored
Adjust parameters of "netdev_dbg" to match alignment with open parenthesis. Issue found using checkpatch.pl Signed-off-by:
-
Madhumitha Prabakaran authored
Fix the check to improve readibility. CHECK: Alignment should match open parenthesis Signed-off-by:
Madhumitha Prabakaran <madhumithabiw@gmail.com> Signed-off-by:
-
Bhanusree Pola authored
Add blank line after the structure declaration, struct fwtty_port *port = tty->driver_data; Issue found using checkpatch.pl Signed-off-by:
-
Bhanusree Pola authored
Fix the checkpatch.pl warning: WARNING:line over 80 characters Move Parameters to the next lines with proper alignment Signed-off-by:
-
Bhanusree Pola authored
Remove unnecesessary extra blank line before the closing brace, to solve the checkpatch.pl check: CHECK: Extra blank line not required before closing brace '}' Signed-off-by:
-
Bhanusree Pola authored
Clear the warning found by checkpatch.pl WARNING:Alignment should match open parenthesis Adjust paremeters in fbtft_par_dbg and write_reg. Signed-off-by:
-
Bhagyashri Dighole authored
Removes the boilerplate license text. Signed-off-by:
Bhagyashri Dighole <digholebhagyashri@gmail.com> Signed-off-by:
-
Bhagyashri Dighole authored
Adds the SPDX GPL-2.0 or BSD-2-clause license identifier, which solves the checkpatch.pl warnings: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by:
-
Bhagyashri Dighole authored
Fix coding style alignment issues detected by checkpatch.pl Match alignments with parenthesis. Limit lines to 80 characters. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Bhanusree Pola authored
Adjust "dev_dbg" parameters to match alignment with open parenthesis Issue found with checkpatch.pl Signed-off-by:
-
Bhanusree Pola authored
Replace 'unsigned' with 'unsigned int' to be specific with data type. Issue found with checkpatch.pl Signed-off-by:
-
- 21 Feb, 2019 3 commits
-
-
Sumit Pundir authored
Fixes misspelled "re-enable" in comment. Reported by checkpatch.pl Signed-off-by:
Sumit Pundir <pundirsumit11@gmail.com> Signed-off-by:
-
Nathan Chancellor authored
Clang warns: drivers/staging/rtlwifi/halmac/halmac_88xx/halmac_func_88xx.c:2472:11: warning: implicit conversion from enumeration type 'enum halmac_cmd_process_status' to different enumeration type 'enum halmac_ret_status' [-Wenum-conversion] return HALMAC_CMD_PROCESS_ERROR; ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Fix this by using the proper enum for allocation failures, HALMAC_RET_MALLOC_FAIL, which is used in the rest of this file. Fixes: e4b08e16 ("staging: r8822be: check kzalloc return or bail") Link: https://github.com/ClangBuiltLinux/linux/issues/375Signed-off-by:Nathan Chancellor <natechancellor@gmail.com> Reviewed-by:
Nicholas Mc Guire <hofrat@osadl.org> Signed-off-by:
-
Bhanusree Pola authored
- adds the SPDX GPL-2.0 license identifier which solves the checkpatch.pl warning - Removed license boilerplate text - Issue found with checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1" Signed-off-by:
-
- 20 Feb, 2019 2 commits
-
-
Gao Xiang authored
page_private(page) cannot be changed if page lock is taken. Besides, the corresponding workgroup won't be freed if the page is already protected by page lock, therefore no need to take rcu read lock. Signed-off-by:
Gao Xiang <gaoxiang25@huawei.com> Reviewed-by:
Chao Yu <yuchao0@huawei.com> Signed-off-by:
-
Gao Xiang authored
In real scenario, there could be several threads accessing xattrs of the same xattr-uninitialized inode, and init_inode_xattrs() almost at the same time. That's actually an unexpected behavior, this patch closes the race. Fixes: b17500a0 ("staging: erofs: introduce xattr & acl support") Cc: <stable@vger.kernel.org> # 4.19+ Reviewed-by:
-
- 19 Feb, 2019 19 commits
-
-
Jann Horn authored
Replace an open-coded version of skb_put_zero() with a call to the helper. This is a cleanup and is also useful for potentially adding KASAN integration to SKBs in the future. Signed-off-by:
Jann Horn <jannh@google.com> Signed-off-by:
-
Bhanusree Pola authored
Align code with open parantheses to improve the readability. Issue found using checkpatch.pl Signed-off-by:
-
Tetsuo Handa authored
syzbot is hitting lockdep warnings [1][2][3]. This patch tries to fix the warning by eliminating ashmem_shrink_scan() => {shmem|vfs}_fallocate() sequence. [1] https://syzkaller.appspot.com/bug?id=87c399f6fa6955006080b24142e2ce7680295ad4 [2] https://syzkaller.appspot.com/bug?id=7ebea492de7521048355fc84210220e1038a7908 [3] https://syzkaller.appspot.com/bug?id=e02419c12131c24e2a957ea050c2ab6dcbbc3270Reported-by:syzbot <syzbot+a76129f18c89f3e2ddd4@syzkaller.appspotmail.com> Reported-by:
syzbot <syzbot+148c2885d71194f18d28@syzkaller.appspotmail.com> Reported-by:
syzbot <syzbot+4b8b031b89e6b96c4b2e@syzkaller.appspotmail.com> Signed-off-by:
-
Bhanusree Pola authored
Use BIT(x) instead of (1<<x), reported by checkpatch.pl. Signed-off-by:
-
YueHaibing authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtlwifi/efuse.c: In function 'efuse_pg_packet_write': drivers/staging/rtlwifi/efuse.c:922:24: warning: variable 'dataempty' set but not used [-Wunused-but-set-variable] drivers/staging/rtlwifi/efuse.c: In function 'efuse_get_current_size': drivers/staging/rtlwifi/efuse.c:1185:5: warning: variable 'hoffset' set but not used [-Wunused-but-set-variable] They're never used and can be removed. Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Signed-off-by:
-
YueHaibing authored
Remove including <linux/version.h> that don't need it. Signed-off-by:
-
Stephen Martin authored
Fixed else block indentation Signed-off-by:
Stephen Martin <lockwood@opperline.com> Signed-off-by:
-
Gustavo A. R. Silva authored
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/staging/vt6656/key.c: In function ‘vnt_set_keymode’: drivers/staging/vt6656/key.c:70:19: warning: this statement may fall through [-Wimplicit-fallthrough=] key->hw_key_idx = entry; ~~~~~~~~~~~~~~~~^~~~~~~ drivers/staging/vt6656/key.c:71:2: note: here case VNT_KEY_ALLGROUP: ^~~~ drivers/staging/vt6656/key.c:73:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (onfly_latch) ^ drivers/staging/vt6656/key.c:75:2: note: here case VNT_KEY_GROUP_ADDRESS: ^~~~ drivers/staging/vt6656/key.c:76:12: warning: this statement may fall through [-Wimplicit-fallthrough=] key_mode |= mode; ~~~~~~~~~^~~~~~~ drivers/staging/vt6656/key.c:77:2: note: here case VNT_KEY_GROUP: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by:Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by:
-
YueHaibing authored
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192e/rtl8192e/rtl_core.c: In function '_rtl92e_tx': drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1732:28: warning: variable 'broad_addr' set but not used [-Wunused-but-set-variable] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:1731:24: warning: variable 'stype' set but not used [-Wunused-but-set-variable] This remove unnessesary bool variable 'multi_addr, broad_addr, uni_addr' Also 'stype' never used and can be removed. Signed-off-by:
-
Sergio Paracuellos authored
Each enabled port is being checked in 'mt7621_pcie_enable_ports" function calling 'mt7621_pcie_enable_port'. The return value for this function on success is zero, so the check is reversed. Fix it. Fixes: 802a2f7b: staging: mt7621-pci: factor out 'mt7621_pcie_enable_port' function Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
There is no need to write IO and memory space window Host PCI bridge registers before doing anything else. Just use its default values which should be ok. Signed-off-by:
NeilBrown <neil@brown.name> Signed-off-by:
-
Sergio Paracuellos authored
To properly follow kernel style replace spaces with tabs in comment where link status bits are explained. Signed-off-by:
-
Sergio Paracuellos authored
There are two definitions which are not being used at all. Remove them. Signed-off-by:
-
Sergio Paracuellos authored
Add general pci reset line to pcie bindings to use reset_control properly in driver code. Signed-off-by:
-
Sergio Paracuellos authored
There is still a reset line which is not being handled using reset_control properly and just being accessing writing registers. Use reset_control instead for pcie general reset line. Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in ODM_RT_TRACE message text, fix it. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Sergio Paracuellos authored
Init driver as 'arch_initcall()' does not work. It causes phy_create() to be called before the phy module is initialized, so 'phy_class' is NULL, the new phy isn't placed in the right class, and it cannot be found. Change to 'module_init()' which works properly in this case. Fixes: 00981d31: staging: mt7621-pci-phy: add new driver for phy part of mt7621-pci Reported-by:
-
Sergio Paracuellos authored
Both pci-phy0 and pci-phy1 are using bad addresses to search for its registers. Use proper register values. Fixes: 06184ba5: staging: mt7621-dts: add pci-phy related bindings to board's device tree Reported-by:
-
Nicholas Mc Guire authored
The kzalloc() in halmac_parse_psd_data_88xx() can fail and return NULL so check the psd_set->data after allocation and if allocation failed return HALMAC_CMD_PROCESS_ERROR. Signed-off-by:
-
