Commit 18341e55 authored by Grégory Wisniewski's avatar Grégory Wisniewski

Remove two XXX and add an entry in the TODO list.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1059 71dcc9de-d417-0410-9af5-da40c76e7ee4
parent 2d5cb3d7
...@@ -113,6 +113,7 @@ RC - Review output of pylint (CODE) ...@@ -113,6 +113,7 @@ RC - Review output of pylint (CODE)
- Make admin node able to monitor multiple clusters simultaneously - Make admin node able to monitor multiple clusters simultaneously
- Choose how to compute the storage size - Choose how to compute the storage size
- Make storage check if the OID match with it's partitions during a store - Make storage check if the OID match with it's partitions during a store
- Send notifications when a storage node is lost
- When importing data, objects with non-allocated OIDs are stored. The - When importing data, objects with non-allocated OIDs are stored. The
storage can detect this and could notify the master to not allocatexd lower storage can detect this and could notify the master to not allocatexd lower
OIDs. But during import, each object stored trigger this notification and OIDs. But during import, each object stored trigger this notification and
......
...@@ -592,10 +592,6 @@ class Application(object): ...@@ -592,10 +592,6 @@ class Application(object):
if node.getState() == TEMPORARILY_DOWN_STATE \ if node.getState() == TEMPORARILY_DOWN_STATE \
and node.getLastStateChange() + expiration < current_time: and node.getLastStateChange() + expiration < current_time:
logging.warning('%s is down, have to notify the admin' % (node, )) logging.warning('%s is down, have to notify the admin' % (node, ))
# XXX: here we should notify the administrator that
# a node seems dead and should be dropped from the
# partition table. This should not be done
# automaticaly to avoid data lost.
node.setState(DOWN_STATE) node.setState(DOWN_STATE)
except OperationFailure: except OperationFailure:
......
...@@ -231,8 +231,6 @@ class NodeManager(object): ...@@ -231,8 +231,6 @@ class NodeManager(object):
if node.getServer() != addr: if node.getServer() != addr:
# address changed, update it # address changed, update it
node.setServer(addr) node.setServer(addr)
# XXX: detect conflicts, but this should not happened
assert node_by_addr is None or node_by_addr is node
logging.debug('update node %s %s %s %s' % log_args) logging.debug('update node %s %s %s %s' % log_args)
node.setState(state) node.setState(state)
else: else:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment