Commit 21bc6205 authored by Vincent Pelletier's avatar Vincent Pelletier

Describe why it is safe to ignore partition changes with more details.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1683 71dcc9de-d417-0410-9af5-da40c76e7ee4
parent 7b0994fd
...@@ -59,8 +59,14 @@ class InitializationHandler(BaseMasterHandler): ...@@ -59,8 +59,14 @@ class InitializationHandler(BaseMasterHandler):
self.app.has_partition_table = True self.app.has_partition_table = True
def notifyPartitionChanges(self, conn, ptid, cell_list): def notifyPartitionChanges(self, conn, ptid, cell_list):
# XXX: Currently it safe to ignore those packets because the master is # XXX: This is safe to ignore those notifications because all of the
# single threaded, it send the partition table without any changes at # following applies:
# the same time. Latter it should be needed to put in queue any changes # - master is monothreaded (notifyPartitionChanges cannot happen
# and apply them when the initial partition is filled. # between sendPartitionTable/answerPartitionTable packets), so
# receiving the whole partition table is atomic
# - we first ask for node information, and *then* partition
# table content, so it is possible to get notifyPartitionChanges
# packets in between (or even before asking for node information).
# - this handler will be changed after receiving answerPartitionTable
# and before handling the next packet
logging.debug('ignoring notifyPartitionChanges during initialization') logging.debug('ignoring notifyPartitionChanges during initialization')
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment