Commit fafff38d authored by Grégory Wisniewski's avatar Grégory Wisniewski

Convert some TODOs in XXXs.

git-svn-id: https://svn.erp5.org/repos/neo/trunk@1458 71dcc9de-d417-0410-9af5-da40c76e7ee4
parent e93492cc
...@@ -768,7 +768,7 @@ class ClientHandlerTests(NeoTestBase): ...@@ -768,7 +768,7 @@ class ClientHandlerTests(NeoTestBase):
dispatcher = self.getDispatcher() dispatcher = self.getDispatcher()
client_handler = StorageAnswersHandler(app) client_handler = StorageAnswersHandler(app)
conn = self.getConnection() conn = self.getConnection()
# TODO: use realistic values # XXX: use realistic values
test_object_data = ('\x00\x00\x00\x00\x00\x00\x00\x01', 0, 0, 0, 0, 'test') test_object_data = ('\x00\x00\x00\x00\x00\x00\x00\x01', 0, 0, 0, 0, 'test')
client_handler.answerObject(conn, None, *test_object_data) client_handler.answerObject(conn, None, *test_object_data)
self.assertEquals(app.local_var.asked_object, test_object_data) self.assertEquals(app.local_var.asked_object, test_object_data)
...@@ -807,7 +807,7 @@ class ClientHandlerTests(NeoTestBase): ...@@ -807,7 +807,7 @@ class ClientHandlerTests(NeoTestBase):
conn = self.getConnection() conn = self.getConnection()
client_handler.answerStoreTransaction(conn, None, test_tid) client_handler.answerStoreTransaction(conn, None, test_tid)
self.assertEquals(len(app.mockGetNamedCalls('setTransactionVoted')), 1) self.assertEquals(len(app.mockGetNamedCalls('setTransactionVoted')), 1)
# TODO: test answerObject with test_tid not matching app.tid (not handled in program) # XXX: test answerObject with test_tid not matching app.tid (not handled in program)
def test_AnswerTransactionInformation(self): def test_AnswerTransactionInformation(self):
class FakeLocal: class FakeLocal:
...@@ -818,14 +818,14 @@ class ClientHandlerTests(NeoTestBase): ...@@ -818,14 +818,14 @@ class ClientHandlerTests(NeoTestBase):
dispatcher = self.getDispatcher() dispatcher = self.getDispatcher()
client_handler = StorageAnswersHandler(app) client_handler = StorageAnswersHandler(app)
conn = self.getConnection() conn = self.getConnection()
tid = '\x00\x00\x00\x00\x00\x00\x00\x01' # TODO: use a more realistic tid tid = '\x00\x00\x00\x00\x00\x00\x00\x01' # XXX: use a more realistic tid
user = 'bar' user = 'bar'
desc = 'foo' desc = 'foo'
ext = 0 # XXX: unused in implementation ext = 0 # XXX: unused in implementation
oid_list = ['\x00\x00\x00\x00\x00\x00\x00\x01', '\x00\x00\x00\x00\x00\x00\x00\x02'] oid_list = ['\x00\x00\x00\x00\x00\x00\x00\x01', '\x00\x00\x00\x00\x00\x00\x00\x02']
client_handler.answerTransactionInformation(conn, None, tid, user, desc, ext, oid_list[:]) client_handler.answerTransactionInformation(conn, None, tid, user, desc, ext, oid_list[:])
stored_dict = app.local_var.txn_info stored_dict = app.local_var.txn_info
# TODO: test 'time' value ? # XXX: test 'time' value ?
self.assertEquals(stored_dict['user_name'], user) self.assertEquals(stored_dict['user_name'], user)
self.assertEquals(stored_dict['description'], desc) self.assertEquals(stored_dict['description'], desc)
self.assertEquals(stored_dict['id'], tid) self.assertEquals(stored_dict['id'], tid)
...@@ -841,7 +841,7 @@ class ClientHandlerTests(NeoTestBase): ...@@ -841,7 +841,7 @@ class ClientHandlerTests(NeoTestBase):
client_handler = StorageAnswersHandler(app) client_handler = StorageAnswersHandler(app)
conn = self.getConnection() conn = self.getConnection()
test_oid = '\x00\x00\x00\x00\x00\x00\x00\x01' test_oid = '\x00\x00\x00\x00\x00\x00\x00\x01'
# TODO: use realistic values # XXX: use realistic values
test_history_list = [(1, 2), (3, 4)] test_history_list = [(1, 2), (3, 4)]
client_handler.answerObjectHistory(conn, None, test_oid, test_history_list[:]) client_handler.answerObjectHistory(conn, None, test_oid, test_history_list[:])
oid, history = app.local_var.history oid, history = app.local_var.history
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment