Commits · 6772d44608dd2f416edd357f5da4094d27f6be29 · nexedi / neoppod

29 Jul, 2009 23 commits

Delete some unused variables. · 6772d446

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1084 71dcc9de-d417-0410-9af5-da40c76e7ee4

6772d446

Remove an XXX and add a TODO entry for this issue. · 86705c29

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1083 71dcc9de-d417-0410-9af5-da40c76e7ee4

86705c29

Remove notifyDeadNode from client app because it's no more used. The client node · 2d1f4090

Grégory Wisniewski authored Jul 29, 2009

never send notifyNodeInformation packets to the master (and don't need to do
this), so remove the associated method handler on the master side and thus
remove an XXX.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1082 71dcc9de-d417-0410-9af5-da40c76e7ee4

2d1f4090

Master recovery handler use PartitionTable.load() that clear the content if the · 04d6a839

Grégory Wisniewski authored Jul 29, 2009

ptid is different. 
Storage node no more use a 'ptid' attribute on the app instance but use the
getID() accessor from the PartitionTable class.
PartitionTable.clear() now also reset the ptid.
PartitionTable.load() do more checks (taken from master.recovery)


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1081 71dcc9de-d417-0410-9af5-da40c76e7ee4

04d6a839

Simplify condition: None is always lower that anything else. · 454bcdb2

Grégory Wisniewski authored Jul 29, 2009

Use max() instead of if <condition>: ...


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1080 71dcc9de-d417-0410-9af5-da40c76e7ee4

454bcdb2

Partial revert of the previous commit. A dead lock was introduced instead of · aeda6d88

Grégory Wisniewski authored Jul 29, 2009

fix a potential bug. The ptid attribute on app is still removed.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1079 71dcc9de-d417-0410-9af5-da40c76e7ee4

aeda6d88

Remove an XXX: _getPartition is no more private because it's now used by the · 9e4f6725

Grégory Wisniewski authored Jul 29, 2009

master handler to ensure that the master connection is well established. Check
of greater ptid received with incremental partition table update is now done by
the PartitionTable class.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1078 71dcc9de-d417-0410-9af5-da40c76e7ee4

9e4f6725

Vincent Pelletier authored Jul 29, 2009

Move all neo-related code from testZODB.py to __init__.py. This reduces dramaticaly the diffs between original testZODB.py and this copy.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1077 71dcc9de-d417-0410-9af5-da40c76e7ee4

1b28f75a

Remove a never read property set on app. · 13009eb6

Vincent Pelletier authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1076 71dcc9de-d417-0410-9af5-da40c76e7ee4

13009eb6

Start a master node. · df5bc052

Vincent Pelletier authored Jul 29, 2009

Use neoctl to start the cluster automatically, and enable all storage nodes.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1075 71dcc9de-d417-0410-9af5-da40c76e7ee4

df5bc052

It is possible to loose a connection before master_conn was set (for example,... · a3dadc1c

Vincent Pelletier authored Jul 29, 2009

It is possible to loose a connection before master_conn was set (for example, when reconnecting to a master being shutdown). Fix this assert to ignore that case.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1074 71dcc9de-d417-0410-9af5-da40c76e7ee4

a3dadc1c

Client node use PartitionTable.load() and ask node informations before partition · 12c970c6
Grégory Wisniewski authored Jul 29, 2009
```
table.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1073 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
12c970c6

Only implement _dropId method in BaseServiceHandler class, as we have no... · 03b71f1e

Vincent Pelletier authored Jul 29, 2009

Only implement _dropId method in BaseServiceHandler class, as we have no broadcast to do except when we are primary master.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1072 71dcc9de-d417-0410-9af5-da40c76e7ee4

03b71f1e

Raise a more specific exception when master connection was interrupted.... · 1ec19260

Vincent Pelletier authored Jul 29, 2009

Raise a more specific exception when master connection was interrupted. NotReadyException should fit this use.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1071 71dcc9de-d417-0410-9af5-da40c76e7ee4

1ec19260

Add a load() on PartitionTable() to remove some logic from handlers, add · 186ec9ae

Grégory Wisniewski authored Jul 29, 2009

docstring and comments.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1070 71dcc9de-d417-0410-9af5-da40c76e7ee4

186ec9ae

Add a TODO entry. · 15d368f0

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1069 71dcc9de-d417-0410-9af5-da40c76e7ee4

15d368f0

Factorize partition table loading with update(). · 86337ecc

Grégory Wisniewski authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1068 71dcc9de-d417-0410-9af5-da40c76e7ee4

86337ecc

Use UUID instead of Node class instance as dictionnary keys. · 0bcad6d5

Vincent Pelletier authored Jul 29, 2009

Make display order of nodes more natural (saves from iterating in node list a second time and factorises code a bit).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1067 71dcc9de-d417-0410-9af5-da40c76e7ee4

0bcad6d5

Unknown storage nodes have to be in temporarily down state. · 4244140f
Grégory Wisniewski authored Jul 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1066 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
4244140f
Add the ptid parameter to update() method of PartitionTable class for · 16e0aefd
Grégory Wisniewski authored Jul 29, 2009
```
consistency.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1065 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
16e0aefd

Fix command line representation. · 74ace0c4

Vincent Pelletier authored Jul 29, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1064 71dcc9de-d417-0410-9af5-da40c76e7ee4

74ace0c4

Update tests to follow changes introduced wiith commit #1032 and avoid crash · 371ae1f5
Grégory Wisniewski authored Jul 29, 2009
```
many tests.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1063 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
371ae1f5
Fix bug introduced with #1058, duplicate OIDs were generated. · e3392cd7
Grégory Wisniewski authored Jul 29, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1062 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
e3392cd7

28 Jul, 2009 17 commits

Remove this XXX, clarify node states is in TODO list. · 104b3ac3
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1061 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
104b3ac3
Move getPartition() in master's pt module for consistency. · 9adb3fe7
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1060 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
9adb3fe7

Remove two XXX and add an entry in the TODO list. · 18341e55

Grégory Wisniewski authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1059 71dcc9de-d417-0410-9af5-da40c76e7ee4

18341e55

Merge getNextOID() and getNewOIDList() to remove an XXX. · 2d5cb3d7
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1058 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
2d5cb3d7

This bug could not be reproduced. Removing. · 41937c5e

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1057 71dcc9de-d417-0410-9af5-da40c76e7ee4

41937c5e

Work done, remove from TODO file. · d96379b4

Vincent Pelletier authored Jul 28, 2009


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1056 71dcc9de-d417-0410-9af5-da40c76e7ee4

d96379b4

Enum class now inherit from dict for integer/Item mapping. · e0019f27

Grégory Wisniewski authored Jul 28, 2009

Remove VALID_* definitions because checks are done in the protocol module when
getting the Item from the integer value.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1055 71dcc9de-d417-0410-9af5-da40c76e7ee4

e0019f27

Fix a forgotten call to Connection.notify providing it a msg_id. Use Connection.answer. · 08849b8b
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1054 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
08849b8b
Fix a forgotten call to Connection.notify providing it a msg_id. Use Connection.answer. · caa3ffe8
Vincent Pelletier authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1053 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
caa3ffe8

Remove those assertions since the debugging stage about node/cell state · dde50609

Grégory Wisniewski authored Jul 28, 2009

inconsistency is finished.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1052 71dcc9de-d417-0410-9af5-da40c76e7ee4

dde50609

Fix admin node knowing a disconnected primary master as being in RUNNING_STATE... · ad90889d

Vincent Pelletier authored Jul 28, 2009

Fix admin node knowing a disconnected primary master as being in RUNNING_STATE (it won't notify its own disconnection !).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1051 71dcc9de-d417-0410-9af5-da40c76e7ee4

ad90889d

Remove some TODO and XXX implemented or put in the TODO list. · ea58c9cb
Grégory Wisniewski authored Jul 28, 2009
```
git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1050 71dcc9de-d417-0410-9af5-da40c76e7ee4
```
ea58c9cb

Remove an XXX comment: it is safe to ignore out of order partition table... · 455cfea7

Vincent Pelletier authored Jul 28, 2009

Remove an XXX comment: it is safe to ignore out of order partition table updates, this is what ptid is for.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1049 71dcc9de-d417-0410-9af5-da40c76e7ee4

455cfea7

Remove an unused "node" local variable (found by pylint). · cfcc8dc3

Vincent Pelletier authored Jul 28, 2009

Avoid using a local variable to display just one in a log.
Fix some inconsistently-named variables.

git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1048 71dcc9de-d417-0410-9af5-da40c76e7ee4

cfcc8dc3

Except during import, no OID overlapping should happen. Remove TODO entries · 3db3bf56

Grégory Wisniewski authored Jul 28, 2009

about this issue and add another about data import improvements.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1047 71dcc9de-d417-0410-9af5-da40c76e7ee4

3db3bf56

Fix Connection.notify prototype. It has no meaning to make it accept a msg_id... · 773cd549

Vincent Pelletier authored Jul 28, 2009

Fix Connection.notify prototype. It has no meaning to make it accept a msg_id parameter (it was used as a dirty work around to Connection.answer which didn't accept a msg id as parameter).


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1046 71dcc9de-d417-0410-9af5-da40c76e7ee4

773cd549

Change Connection.answer prototype: it now takes a msg_id as parameter, not a... · c109d56c

Vincent Pelletier authored Jul 28, 2009

Change Connection.answer prototype: it now takes a msg_id as parameter, not a message any longer. This make this method easier to call from places where the entire message might not be available.


git-svn-id: https://svn.erp5.org/repos/neo/branches/prototype3@1045 71dcc9de-d417-0410-9af5-da40c76e7ee4

c109d56c