Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !272

Merged
Created Dec 10, 2020 by Jérome Perrin@jeromeOwner

cli: Output on the console even with --log-file

  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 2

In 51f89902 (slapos/cli/entry.py, slapos/cli/format.py, slapos/format.py: Do not double the log output when "slapos node boot" failed., 2017-05-11) we fixed a problem that every failure during boot causing twice more output (which filled up the disk very fast), but a side effect was that using --log-file no longer cause messages to also go to the console.

The "Always send higher-level messages to the console via stderr" comment in entry.py seems that this was always intentional to output messages on the console.

Keep the same "don't configure again logging system when it's already configured", but implemented in a slightly different way, because since a FileHandler is a StreamHandler, the check of already having a StreamHandler was true also for the case where --log-file added a FileHander (a few lines above, also in configure_logging method)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/output-console
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7