Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !273

Merged
Created Dec 10, 2020 by Jérome Perrin@jeromeOwner

proxy: don't set app logger level

  • Overview 6
  • Commits 1
  • Pipelines 4
  • Changes 2

logging is configured globally in SlapOSApp.configure_logging and:

  • if logging to file is enabled, it is logged with maximum level
  • logging on the console depends on --quiet / --verbose command line flags

Default log level of this logger was DEBUG, which is just fine: the logger emit all messages and the file/console handler decide to output them or not

Because we configure logger after Flask initialize its own logging, for Flask >= 1.1.2, we remove Flask logger as described in https://flask.palletsprojects.com/en/1.1.x/logging/#removing-the-default-handler

Since this is internal API which doest not exist on old version of Flask, we adjust requirements to require a recent version of Flask.

Edited Feb 04, 2021 by Jérome Perrin
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/proxy-output
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7