Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !333

Merged
Created Sep 24, 2021 by Jérome Perrin@jeromeOwner

grid: fix "log buildout output in realtime"

  • Overview 12
  • Commits 1
  • Pipelines 1
  • Changes 2

this fixes 86ce8b8e which had an error the current_output variable was not reset when the current output ended in \n.

As a result, logged output was sometimes containing some parts of the program output twice. We could even catch it in unit test, when running the test multiple times. It also happened on test node with https://erp5js.nexedi.net/#/test_result_module/20210826-1706D7F50/10

The is trivial, we reset the current output also in this case. The test suite is extended a bit, with added tests and test adjustments made during the debugging. With test_exec_large_output_multiline the problem triggers almost every time.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix/realtime-output-fix
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7