slapos/proxy: setComputerPartitionConnectionXml don't update timestamp (!151) · Merge Requests · nexedi / slapos.core · GitLab

slapos/proxy: setComputerPartitionConnectionXml don't update timestamp

This operation is done by the instance itself, updating the timestamp here will create an infinity call, where the instance is always edited and it is forced to run.

At the ERP5 implementation of slapos master this api don't modify the timestamp (which is not defined by modification date but by an specific workflow.

Edited 2019-11-05 14:05:30 UTC

Request to merge rafael:bug-proxy-timestamp into master

Discussion 3
Commits 1
Changes 1
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved

@rafael Rafael Monnerat
@rafael commented 2019-10-31 19:23:18 UTC

Owner

It seems to work but I still need to check if I didn't caused a regression on the tests
@jerome Jérome Perrin
@jerome commented 2019-11-01 13:12:54 UTC

Owner

it seems this code was introduced recently in b69b44f7

I don't know this code and I trust you on this :)
@rafael Rafael Monnerat
@rafael commented 2019-11-05 14:05:25 UTC

Owner

the tests passed (PY3 and PY2), and in production seems also ok.
@rafael Rafael Monnerat
@rafael
mentioned in commit 9d796b73
2019-11-05 14:05:28 UTC

mentioned in commit 9d796b73

Toggle commit list
@rafael Rafael Monnerat
@rafael
merged
2019-11-05 14:05:29 UTC

merged

Toggle commit list

Please register or sign in to post a comment