recipe/request: Log if request fails

/reviewed-on nexedi/slapos!166

slapos/recipe/request.py

@@ -170,6 +170,20 @@ class Recipe(object):
           # Backward compatibility. Old SlapOS master and core don't know this.
           self.logger.warning("Impossible to fetch instance GUID nor state.")
     except (slapmodule.NotFoundError, slapmodule.ServerError, slapmodule.ResourceNotReady) as exc:
+      self.logger.warning(
+        'Request for %(request_name)r with software release '
+        '%(software_release)r and software type %(software_type)r failed '
+        'with partition_parameter_kw=%(partition_parameter_kw)r, '
+        'filter_kw=%(filter_kw)r, shared=%(shared)r, state=%(state)r.' % dict(
+          software_release=software_url,
+          software_type=software_type,
+          request_name=name,
+          partition_parameter_kw=partition_parameter_kw,
+          filter_kw=filter_kw,
+          shared=slave,
+          state=requested_state
+        )
+      )
       self._raise_request_exception = exc
       self._raise_request_exception_formatted = traceback.format_exc()
       return_parameter_dict = {}

[Julien Muchembled]

Do not use %. Let the logging module format the message from extra arguments. For example:

>>> import logging
>>> logging.error('%s:%s', 'foo', 'bar')
ERROR:root:foo:bar
>>> logging.error('%(foo)s', dict(foo='bar'))
ERROR:root:bar

[Łukasz Nowak]

Thanks @jm, done in 3f73965c , as fixup, b/c the MR has been already merged.