Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !1555

Merged
Created Mar 25, 2024 by Kirill Smelkov@kirrOwner

software/ors-amarisoft: Workaround SlapOS Master inability to handle shared...

  • Overview 8
  • Commits 1
  • Changes 5

software/ors-amarisoft: Workaround SlapOS Master inability to handle shared instances of multiple types

While upcoming SlapOS Master should be able to handle multiple types of shared instances attached to the same main instance, current SlapOS Master UI does not handle it well, and explicitly rejected to do so with dae3ad01 , which turned json-schemas check failing for ors-amarisoft as

FAIL: test_ors-amarisoft_software_cfg_json (slapos.test.test_json_schema.TestJSONSchemaValidation)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".../slapos/slapos/test/test_json_schema.py", line 81, in run
    assert _software_type_tuple not in _viewed_software_type, \
AssertionError: Duplicated software release on enb, shared: True

-> Work it around by adjusting software.cfg.json to use only one type of shared instance for each main instance, and inside schema of that type dispatch to all needed subtypes with oneOf.

This patch should be reverted when/if SlapOS Master starts to handle shared instances of multiple types well.

/cc @tomo, @jhuge, @lu.xu, @xavier_thompson, @Daetalus, @romain, @rafael, @jerome

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: y/software.cfg.json
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7