Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
slapos slapos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 122
    • Merge requests 122
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slaposslapos
  • Merge requests
  • !1616

Merged
Created Jul 26, 2024 by Rafael Monnerat@rafael👻Owner

kvm/theia: Dont use allOf on resilient to extend properties

  • Overview 4
  • Commits 1
  • Changes 2

allOf implies that all (both) schemas should be valid, but additionalProperties false wont allow it, since it become multually invalid. (You can validate only one or None)

Just use $ref to expand the list, it end up with the expected outcome reducing complexity.

Note: kvm wasn't using additionalProperties false but it was changed because it makes it future proof, in case we set it (we should set).

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: resilient-schema-allof-fixup
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7