Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
W wendelin.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • nexedi
  • wendelin.core
  • Merge requests
  • !33

Open
Created Nov 04, 2024 by Levin Zimmermann@levin.zimmermannMaintainer
  • Report abuse
Report abuse

Fix false alarm about faulty client whereas client just restarted at pin time

  • Overview 1
  • Commits 2
  • Changes 2

Good day, Kirill,

this MR is about a minor issue that we observed on our recently deployed production instance. We could see that zopes were sometimes killed by WCFS (according to WCFS statistics and WCFS log). However, in zope logs we couldn't find any SIGKILL traces, but we could see that whenever WCFS killed zopes, it was just shortly after zopes restarted.

Due to this, I have the assumption that WCFS attempted to kill zopes that just restarted after receiving a pin request. In other words, these clients didn't respond anymore, because they were already dead.

In order to check if my assumption is true, I added hereby provided tests that simulate clients that exit at pin time. I also added a proposal for a fix of this issue.

Generally, from my current understanding, this issue looks relatively tame (and therefore less important than the deadlock issue). However, if it doesn't get fixed, it could cover real problems with clients, and therefore it's still good to find a solution for it earlier or later.

Best, Levin

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: fix-kill-dead-client
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7