1. 06 Aug, 2015 4 commits
    • Reinout van Rees's avatar
      Merge pull request #255 from mauritsvanrees/maurits-check-use-dependency-links-earlier · eb0bc6bd
      Reinout van Rees authored
      Check the 'use-dependency-links' option earlier.
      eb0bc6bd
    • Maurits van Rees's avatar
      Check the 'use-dependency-links' option earlier. · 30683a0d
      Maurits van Rees authored
      This can give a small speed increase.
      
      Before this, for each dist we would first check if it had a dependency
      links option, which is almost always the case, but it is usually
      empty: the package *will* have a dependency_links.txt in its EGG-INFO,
      but there is only an empty line in it.
      
      When you have a lot of packages and several buildout parts that use
      them, the dependency links can be checked a lot of times.
      
      On an extended Plone buildout with 'use-dependency-links=false', where
      get_dist was called over 2500 times, the difference was 0.1 seconds,
      so not much.  When I/O is slow, the difference could be more
      noticeable.
      
      Note that actually setting 'use-dependency-links' to false, already
      helps much more.  For this buildout it shaved off 1.5 seconds.
      
      Note that the 0.1 seconds win is because we do not have to call
      'os.exists' for all those files, and the 1.5 seconds win is because we
      do not have to actually read those files.
      
      Also, for completeness sake, note that in this buildout get_dist was
      called lots of times, but the list of dists that we checked for
      dependency links in this method was always just a list of one.  So we
      could have simply switched the order of the three parts of the
      condition around with the same effect (and a smaller diff).  Still,
      the way I did it now seems better.
      
      And I am probably explaining myself much much more than is needed. :-)
      30683a0d
    • Jim Fulton's avatar
      Merge pull request #254 from mauritsvanrees/maurits-fix-bootstrap-typo · 84053ef6
      Jim Fulton authored
      Fixed bootstrap help text: --buildout-version.
      84053ef6
    • Maurits van Rees's avatar
      9ba1e317
  2. 01 Jul, 2015 21 commits
  3. 30 Jun, 2015 12 commits
  4. 29 Jun, 2015 3 commits
    • Reinout van Rees's avatar
      Updated changelog · 94a5f2d4
      Reinout van Rees authored
      94a5f2d4
    • Reinout van Rees's avatar
      In-place editing of os.walk results · 1030b3c6
      Reinout van Rees authored
      The [:] is necessary to edit the os.walk results in-place. Otherwise the
      filtering-out of .svn, CVS and so doesn't work as intended.
      (Note: this regression I put in was caught by one of the tests! Good that
      we've got such a large amount of tests!)
      1030b3c6
    • Reinout van Rees's avatar
      Properly handling non-ascii filenames in hashing function · be8bc821
      Reinout van Rees authored
      Added fs_to_text() function that ensures a filename is always unicode (python
      2) or str (python 3).
      
      os.walk() gets such a unicode dirname as start point, so that it tries to do
      its best on python2. The resulting filenames are converted to unicode to make
      really sure that the join() doesn't fail with a decoding error.
      
      The input to the hash function is encoded, as it gives an ascii encoding error
      otherwise on python 2.
      be8bc821