• Kirill Smelkov's avatar
    zc.recipe.egg: Support environment in :develop · b3381ef0
    Kirill Smelkov authored
    Currently only zc.recipe.egg:custom supports setting environment
    variables, and zc.recipe.egg:develop does not.
    
    My motivation for allowing setting environment in :develop is
    wendelin.core
    
        https://lab.nexedi.cn/nexedi/slapos/blob/b5faab3b/component/wendelin.core/buildout.cfg
    
    There we have [wendelin.core] part which installs released egg from
    pypi, and [wendelin.core-dev] part which installs wendelin.core from
    its latest git version via zc.recipe.egg:develop .
    
    The problem is, wendelin.core for setup.py to work, needs git available,
    and with slapos we usually don't have git available on base system, so
    we build it by our own and do something like
    
        [wendelin.core-dev]
        recipe = zc.recipe.egg:develop
        environment = wendelin.core-dev-env
    
        [wendelin.core-dev-env]
        # wendelin.core-dev needs git to build
        PATH = ${git:location}/bin:%(PATH)s
    
    and the problem is environment does not currently work for
    zc.recipe.egg:develop, and thus git is not found -> build fails.
    
    ~~~~
    
    In order to support environment in :develop, we just move environment
    setting/restoring bits from Custom to Base, and provide Base.install() which
    uses this bits. Custom & Develop .install() becomes ._install() which gets
    hooked into Base.install() .
    
    I've tested the patch only manually, because currently automated tests are
    broken in a lot of places for slapos.buildout and zc.recipe.egg .
    
    /cc @kazuhiko, @Tyagov
    b3381ef0
Name
Last commit
Last update
bootstrap Loading commit data...
doc Loading commit data...
specifications Loading commit data...
src/zc Loading commit data...
z3c.recipe.scripts_ Loading commit data...
zc.recipe.egg_ Loading commit data...
.bzrignore Loading commit data...
CHANGES.txt Loading commit data...
DEVELOPERS.txt Loading commit data...
MANIFEST.in Loading commit data...
README.txt Loading commit data...
SYSTEM_PYTHON_HELP.txt Loading commit data...
buildout.cfg Loading commit data...
dev.py Loading commit data...
setup.py Loading commit data...
test_all_pythons.cfg Loading commit data...
todo.txt Loading commit data...