Test that forbid-download-cache works

.gitignore

 *pyc
-build
+/build
 dist
 slapos.recipe.build.egg-info

slapos/recipe/build/tests.py

+from zope.testing import doctest
+from zope.testing import renormalizing
+
+import os
+import re
+import shutil
+import stat
+import tempfile
+import unittest
+import zc.buildout.testing
+import zc.buildout.tests
+
+optionflags =  (doctest.ELLIPSIS |
+                doctest.NORMALIZE_WHITESPACE)
+
+GIT_REPOSITORY = 'http://git.erp5.org/repos/slapos.recipe.build.git'
+BAD_GIT_REPOSITORY = 'http://git.erp5.org/repos/nowhere'
+REVISION = '2566127'
+
+def setUp(test):
+    zc.buildout.testing.buildoutSetUp(test)
+    zc.buildout.testing.install_develop('slapos.recipe.build', test)
+
+class GitCloneNonInformativeTests(unittest.TestCase):
+
+    def setUp(self):
+        self.dir = os.path.realpath(tempfile.mkdtemp())
+
+    def tearDown(self):
+        shutil.rmtree(self.dir)
+        for var in os.environ.keys():
+            if var.startswith('SRB_'):
+                del os.environ[var]
+
+    def write_file(self, filename, contents, mode=stat.S_IREAD | stat.S_IWUSR):
+        path = os.path.join(self.dir, filename)
+        fh = open(path, 'w')
+        fh.write(contents)
+        fh.close()
+        os.chmod(path, mode)
+        return path
+
+    def make_recipe(self, buildout, name, options):
+        from slapos.recipe.gitclone import Recipe
+        parts_directory_path = os.path.join(self.dir, 'test_parts')
+
+        bo = {
+            'buildout': {
+                'parts-directory': parts_directory_path,
+                'directory': self.dir,
+            }
+        }
+        bo.update(buildout)
+        return Recipe(bo, name, options)
+
+    def test_using_download_cache_if_git_fails(self):
+        from slapos.recipe.gitclone import GIT_CLONE_ERROR_MESSAGE, \
+            GIT_CLONE_CACHE_ERROR_MESSAGE
+        recipe = self.make_recipe({}, 'test', {
+            'repository': BAD_GIT_REPOSITORY,
+            'forbid-download-cache': 'false',
+        })
+        os.chdir(self.dir)
+        try:
+            recipe.install()
+            # Should have raised before.
+            self.assertTrue(False)
+        except zc.buildout.UserError, e:
+          self.assertEquals(e.message, GIT_CLONE_CACHE_ERROR_MESSAGE)
+
+    def test_not_using_download_cache_if_forbidden(self):
+        from slapos.recipe.gitclone import GIT_CLONE_ERROR_MESSAGE, \
+            GIT_CLONE_ERROR_MESSAGE
+        recipe = self.make_recipe({}, 'test', {
+            'repository': BAD_GIT_REPOSITORY,
+            'forbid-download-cache': 'true',
+        })
+        os.chdir(self.dir)
+        try:
+            recipe.install()
+            # Should have raised before.
+            self.assertTrue(False)
+        except zc.buildout.UserError, e:
+          self.assertEquals(e.message, GIT_CLONE_ERROR_MESSAGE)
+
+def test_suite():
+    suite = unittest.TestSuite((
+            doctest.DocFileSuite(
+                'README.rst',
+                module_relative=False,
+                setUp=setUp,
+                tearDown=zc.buildout.testing.buildoutTearDown,
+                optionflags=optionflags,
+                checker=renormalizing.RENormalizing([
+                        zc.buildout.testing.normalize_path,
+                        (re.compile(r'http://localhost:\d+'), 'http://test.server'),
+                        # Clean up the variable hashed filenames to avoid spurious test failures
+                        (re.compile(r'[a-f0-9]{32}'), ''),
+                        ]),
+                ),
+            unittest.makeSuite(GitCloneNonInformativeTests),
+            ))
+    return suite
+
+if __name__ == '__main__':
+    unittest.main(defaultTest='test_suite')

slapos/recipe/gitclone.py

@@ -53,6 +53,10 @@ GIT_DEFAULT_REMOTE_NAME = 'origin'
 GIT_DEFAULT_BRANCH_NAME = 'master'
 TRUE_VALUES = ['y', 'yes', '1', 'true']
 
+GIT_CLONE_ERROR_MESSAGE = 'Impossible to clone repository.'
+GIT_CLONE_CACHE_ERROR_MESSAGE = 'Impossible to clone repository and ' \
+    'impossible to download from cache.'
+
 def upload_network_cached(path, name, revision, networkcache_options):
   """
   Creates uploads repository to cache.
@@ -185,11 +189,10 @@ class Recipe(object):
       if os.path.exists(self.location):
         shutil.rmtree(self.location)
       if self.forbid_download_cache:
-        raise UserError('Impossible to clone repository.')
+        raise UserError(GIT_CLONE_ERROR_MESSAGE)
       if not download_network_cached(self.location, self.name, self.revision,
           self.networkcache):
-        raise UserError('Impossible to clone repository and impossible to '
-            'download from cache.')
+        raise UserError(GIT_CLONE_CACHE_ERROR_MESSAGE)
 
     return [self.location]