slapos_crm: Make test independent of the Notification Messages

  Mock NotificationTool_getDocumentValue to ensure the None as return value, in order to not find eventual valid notification messages with random content from other tests or dev environment.

  No need to assert entire message, it is enought to assert message isn't empty and assert a subset of it.

master/bt5/slapos_crm/TestTemplateItem/portal_components/test.erp5.testSlapOSCRMRegularisationRequestSkins.py

@@ -30,6 +30,10 @@ import difflib
 
 class TestSlapOSPerson_checkToCreateRegularisationRequest(SlapOSTestCaseMixinWithAbort):
 
+  @simulate('NotificationTool_getDocumentValue',
+            'reference=None, language="en"',
+  'assert reference == "slapos-crm.create.regularisation.request"\n' \
+  'return')
   @simulate('Entity_statOutstandingAmount', '*args, **kwargs', 'return "1"')
   def test_addRegularisationRequest_payment_requested(self):
     for preference in \
@@ -637,6 +641,10 @@ class TestSlapOSRegularisationRequest_checkToTriggerNextEscalationStep(
       0, ticket.getRelativeUrl(), '', '', '', ''
       )
 
+  @simulate('NotificationTool_getDocumentValue',
+            'reference=None, language="en"',
+  'assert reference == "slapos-crm.acknowledgment.escalation", reference\n' \
+  'return')
   @simulate('RegularisationRequest_checkToSendUniqEvent',
             'service_relative_url, title, text_content, comment, REQUEST=None',
   'context.portal_workflow.doActionFor(' \
@@ -822,6 +830,10 @@ class TestSlapOSRegularisationRequest_triggerAcknowledgmentEscalation(
       ticket.RegularisationRequest_triggerAcknowledgmentEscalation,
       REQUEST={})
 
+  @simulate('NotificationTool_getDocumentValue',
+            'reference=None, language="en"',
+  'assert reference == "slapos-crm.acknowledgment.escalation", reference\n' \
+  'return')
   @simulate('RegularisationRequest_checkToTriggerNextEscalationStep',
             'delay_period_in_days, current_service_relative_url, next_service_relative_url, title, text_content, comment, REQUEST=None',
   'context.portal_workflow.doActionFor(' \
@@ -894,6 +906,10 @@ class TestSlapOSRegularisationRequest_triggerStopReminderEscalation(
       ticket.RegularisationRequest_triggerStopReminderEscalation,
       REQUEST={})
 
+  @simulate('NotificationTool_getDocumentValue',
+            'reference=None, language="en"',
+  'assert reference == "slapos-crm.stop.reminder.escalation", reference\n' \
+  'return')
   @simulate('RegularisationRequest_checkToTriggerNextEscalationStep',
             'delay_period_in_days, current_service_relative_url, next_service_relative_url, title, text_content, comment, REQUEST=None',
   'context.portal_workflow.doActionFor(' \
@@ -966,6 +982,10 @@ class TestSlapOSRegularisationRequest_triggerStopAcknowledgmentEscalation(
       ticket.RegularisationRequest_triggerStopAcknowledgmentEscalation,
       REQUEST={})
 
+  @simulate('NotificationTool_getDocumentValue',
+            'reference=None, language="en"',
+  'assert reference == "slapos-crm.stop.acknowledgment.escalation", reference\n' \
+  'return')
   @simulate('RegularisationRequest_checkToTriggerNextEscalationStep',
             'delay_period_in_days, current_service_relative_url, next_service_relative_url, title, text_content, comment, REQUEST=None',
   'context.portal_workflow.doActionFor(' \
@@ -1038,6 +1058,10 @@ class TestSlapOSRegularisationRequest_triggerDeleteReminderEscalation(
       ticket.RegularisationRequest_triggerDeleteReminderEscalation,
       REQUEST={})
 
+  @simulate('NotificationTool_getDocumentValue',
+            'reference=None, language="en"',
+  'assert reference == "slapos-crm.delete.reminder.escalation", reference\n' \
+  'return')
   @simulate('RegularisationRequest_checkToTriggerNextEscalationStep',
             'delay_period_in_days, current_service_relative_url, next_service_relative_url, title, text_content, comment, REQUEST=None',
   'context.portal_workflow.doActionFor(' \

master/bt5/slapos_crm/TestTemplateItem/portal_components/test.erp5.testSlapOSCRMSkins.py

@@ -1916,8 +1916,8 @@ class TestSupportRequestUpdateMonitoringState(SlapOSTestCaseMixin):
   @simulate('ERP5Site_isSupportRequestCreationClosed', '','return 0')
   @simulate('SupportRequest_trySendNotificationMessage',
             "message_title, message, source_relative_url",
-     'return "Visited by SupportRequest_trySendNotificationMessage '\
-  '%s %s %s" % (message_title, message, source_relative_url)')
+     """assert "destroyed" in message
+return "Visited by SupportRequest_trySendNotificationMessage %s %s" % (message_title, source_relative_url)""")
   def testSupportRequest_updateMonitoringDestroyRequestedState(self):
     support_request = self._makeSupportRequest()
     self.assertEqual(None,
@@ -1938,8 +1938,7 @@ class TestSupportRequestUpdateMonitoringState(SlapOSTestCaseMixin):
     self.commit()
 
     support_request.setDestinationDecisionValue(self.makePerson(user=0))
-    expected_text = """Visited by SupportRequest_trySendNotificationMessage Hosting Subscription was destroyed was destroyed by the user  Closing this ticket as the Hosting Subscription was destroyed by the user. 
-   %s""" % support_request.getDestinationDecision()
+    expected_text = """Visited by SupportRequest_trySendNotificationMessage Hosting Subscription was destroyed was destroyed by the user %s""" % support_request.getDestinationDecision()
     self.assertEqual(expected_text,
       support_request.SupportRequest_updateMonitoringDestroyRequestedState())