- 01 Mar, 2024 15 commits
-
-
Rafael Monnerat authored
See merge request nexedi/erp5!1893
-
Jérome Perrin authored
This uses `from __future__ import print_function` from "unrestricted" python code. For restricted python in python scripts, this expects SlapOS to have nexedi/slapos!1536 . Running ERP5 with this patch on an old SlapOS software release should probably be OK, especially because after all we don't have so much critical code using print. To ease migration of custom project code, PythonCodeUtils was modified so that when running CodingStyle python scripts are checked with print_function future enabled. See merge request nexedi/erp5!1883
-
Rafael Monnerat authored
Since the test() method was fixed the comment became irrelevant
-
Łukasz Nowak authored
Returning true allows to add movements to existing one, and this group shall always separate them.
-
Léo-Paul Géneau authored
See merge request !1891
-
Léo-Paul Géneau authored
Rename triggerParachute function into land in DroneManager for compliance with multicopters APIs.
-
Nicolas Wavrant authored
See merge request nexedi/erp5!1880
-
Nicolas Wavrant authored
I investigated a case where activities calling an external API were not retried after the initial failure, when it was caused by TimeoutReachedError: https://lab.nexedi.com/nexedi/erp5/-/blob/f41b33cd91348a800db3b95b30efd857f583bcde/bt5/erp5_web_service/MixinTemplateItem/portal_components/mixin.erp5.RESTAPIClientConnectorMixin.py#L142 The interesting thing is that these activities are written in a way that allow them to be retried (automatically, or manually) without causing un-intended side effects, like creating twice a document in the external API. So not having SQLBase retrying them automatically is a pity. The bug is that the use of TimeoutReachedError here was intended only for the activities that are aborted by CMFActivity itself, and not for the userland code that can also use TimeoutReachedError. This commit removes this special processing, as there is no need to especially not retry the activities that trigger the CMFActivity timeout. The max_retry decision should be taken by the calling code, and not by CMFActivity.
-
Jérome Perrin authored
This flags python2 style usage of print as a statement
-
Jérome Perrin authored
-
Kazuhiko Shiozaki authored
(not yet for scripts under portal_skins) adjusted (by Jérome) to just remove call to print in a few places where it made more sense.
-
Kazuhiko Shiozaki authored
-
Jérome Perrin authored
-
Rafael Monnerat authored
See merge request nexedi/erp5!1889
-
Rafael Monnerat authored
See merge request nexedi/erp5!1887
-
- 29 Feb, 2024 20 commits
-
-
Rafael Monnerat authored
-
Rafael Monnerat authored
Move Simulation to priority 3 helps to not block/delay immediateReindex on a scenario where everything is expanding. We use priority 3 to match what is used in SimulableMixin.updateSimulation and Delivery.localBuild
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Romain Courteaud authored
-
Jérome Perrin authored
This fixes compatibility for python3, especially with hash randomization (PYTHONHASHSEED) turned on. This also enables coding style test that was not running for this bt, after fixing everything flagged by coding style test. See merge request nexedi/erp5!1892
-
Jérome Perrin authored
Make sure we see *all* warnings, both in the tests and in the logfile in production. Fix many warnings by updating imports and calls to deprecated APIs See merge request !1879
-
Jérome Perrin authored
for consistency and because it's probably good to let user choose sending mode.
-
Jérome Perrin authored
This matches the form title
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
-
Jérome Perrin authored
When producing DSN report, there was a few places where we depended on dict iteration order, so the test did not pass when running with PYTHONHASHSEED (erp5_payroll_l10n_fr:testDSNSocialDeclarationReport fails with PYTHONHASHSEED 323). In these changes we add sorts to some places where we were iterating on dicts so that the order of the Lines is deterministic even with hash randomization enabled. Co-authored-by: Nicolas Wavrant <nicolas.wavrant@nexedi.com>
-
Jérome Perrin authored
test was simplified not to use difflib, unittest does a good job of explaining the differences when using splitlines on long texts, no need to compute a diff ourselves.
-
Jérome Perrin authored
-
- 28 Feb, 2024 5 commits
-
-
Rafael Monnerat authored
Without this the redirection places value unquoted causing parser to fail later on when resolve {n.me}. came_from cannot be None so we simplify the block a bit.
-
Rafael Monnerat authored
See merge request nexedi/erp5!1888
-
Rafael Monnerat authored
-
Jérome Perrin authored
-
Jérome Perrin authored
This makes it easier to find the problematic listbox and also report once per listbox.
-