stack walker typo and improvement

4d57da10 · Brendan Gregg · 38cef486 · 4d57da10 · 4d57da10 · 4d57da10
Commit 4d57da10 authored Jan 19, 2016 by Brendan Gregg
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 5 deletions

tools/offcputime tools/offcputime +1 -1

tools/stackcount tools/stackcount +3 -3

tools/stacksnoop tools/stacksnoop +1 -1

No files found.
--- a/tools/offcputime
+++ b/tools/offcputime
@@ -74,7 +74,7 @@ static u64 get_frame(u64 *bp) {
        if (bpf_probe_read(&ret, sizeof(ret), (void *)(*bp+8)))
            return 0;
        if (bpf_probe_read(bp, sizeof(*bp), (void *)*bp))
-            bp = 0;
+            *bp = 0;
        if (ret < __START_KERNEL_map)
            return 0;
        return ret;

--- a/tools/stackcount
+++ b/tools/stackcount
@@ -86,10 +86,10 @@ static u64 get_frame(u64 *bp) {
        u64 ret = 0;
        if (bpf_probe_read(&ret, sizeof(ret), (void *)(*bp+8)))
            return 0;
-        if (!ret || ret < __START_KERNEL_map)
-            return 0;
        if (bpf_probe_read(bp, sizeof(*bp), (void *)*bp))
-            bp = 0;
+            *bp = 0;
+        if (ret < __START_KERNEL_map)
+            return 0;
        return ret;
    }
    return 0;

--- a/tools/stacksnoop
+++ b/tools/stacksnoop
@@ -56,7 +56,7 @@ static int print_frame(u64 *bp, int *depth) {
        u64 ret = 0;
        if (bpf_probe_read(&ret, sizeof(ret), (void *)(*bp+8)))
            return 0;
-        if (!ret || ret < __START_KERNEL_map)
+        if (ret < __START_KERNEL_map)
            return 0;
        bpf_trace_printk("r%d: %llx\\n", *depth, ret);
        if (bpf_probe_read(bp, sizeof(*bp), (void *)*bp))