Commit cb136c15 authored by Yonghong Song's avatar Yonghong Song

fix tcplife.py rewriter issue

rewriter tried to rewrite an argument for a user written
bpf_probe_read and triggers a clang compilation error.

  $ tcplife.py
  /virtual/main.c:134:41: error: cannot take the address of an rvalue of type 'typeof(u64)' (aka 'unsigned long long')
    ...&({ typeof(u64) _val; __builtin_memset(&_val, 0, sizeof(_val)); bpf_probe_read(&_val, sizeof(_val), (u64)&tp->bytes_received); _val; }));
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /virtual/main.c:135:41: error: cannot take the address of an rvalue of type 'typeof(u64)' (aka 'unsigned long long')
    ...&({ typeof(u64) _val; __builtin_memset(&_val, 0, sizeof(_val)); bpf_probe_read(&_val, sizeof(_val), (u64)&tp->bytes_acked); _val; }));
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  2 errors generated.

changing bpf_probe_read to regular pointer access fixed the issue.
Signed-off-by: default avatarYonghong Song <yhs@fb.com>
parent eee383cf
...@@ -311,8 +311,8 @@ TRACEPOINT_PROBE(sock, inet_sock_set_state) ...@@ -311,8 +311,8 @@ TRACEPOINT_PROBE(sock, inet_sock_set_state)
// get throughput stats. see tcp_get_info(). // get throughput stats. see tcp_get_info().
u64 rx_b = 0, tx_b = 0, sport = 0; u64 rx_b = 0, tx_b = 0, sport = 0;
struct tcp_sock *tp = (struct tcp_sock *)sk; struct tcp_sock *tp = (struct tcp_sock *)sk;
bpf_probe_read(&rx_b, sizeof(rx_b), &tp->bytes_received); rx_b = tp->bytes_received;
bpf_probe_read(&tx_b, sizeof(tx_b), &tp->bytes_acked); tx_b = tp->bytes_acked;
if (args->family == AF_INET) { if (args->family == AF_INET) {
struct ipv4_data_t data4 = {.span_us = delta_us, struct ipv4_data_t data4 = {.span_us = delta_us,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment