1. 19 Sep, 2018 1 commit
  2. 18 Sep, 2018 1 commit
    • yonghong-song's avatar
      fix a trace.py problem (#1973) · 61484e17
      yonghong-song authored
      Currently, trace.py failed for the following command:
        $ sudo ./trace.py 'filename_lookup(int dfd, struct filename *name) "%s", name->name'
        ...
        0: (bf) r6 = r1
        1: (79) r7 = *(u64 *)(r6 +104)
        ...
        32: (15) if r1 == 0x0 goto pc+5
        R0=inv(id=0) R1=inv(id=0) R6=ctx(id=0,off=0,imm=0) R7=inv(id=0)
        R8=inv0 R10=fp0,call_-1 fp-8=0 fp-16=0 fp-24=0 fp-32=0 fp-40=0 fp-48=0 fp-56=0 fp-64=0 fp-72=0 fp-80=0
        33: (79) r3 = *(u64 *)(r7 +0)
        R7 invalid mem access 'inv'
      
      For string format argument, the trace.py generates the below code:
              if (name->name != 0) {
                      bpf_probe_read(&__data.v0, sizeof(__data.v0), (void *)name->name);
              }
      Right now, bcc skips the rewriter for the third argument of bpf_probe_read to avoid
      unnecessary nested bpf_probe_read and other potential issues.
      This causes name->name memory access not transformed with bpf_probe_read and hence
      the verifier complains.
      
      To fix the issue, this patch did the following transformation using an
      temporary variable to hold the src address:
              if (name->name != 0) {
                      void *__tmp = (void *)name->name;
                      bpf_probe_read(&__data.v0, sizeof(__data.v0), __tmp);
              }
      This way, rewriter can do the work properly.
      Signed-off-by: default avatarYonghong Song <yhs@fb.com>
      61484e17
  3. 13 Sep, 2018 2 commits
    • Nguyen Phuong An's avatar
      Fix syntax error in xdp_redirect_cpu.py (#1969) · 0cae0dd3
      Nguyen Phuong An authored
      Fix syntax error in xdp_redirect_cpu.py
      0cae0dd3
    • zlim's avatar
      Enable Ubuntu/arm64 deb packaging (#1968) · 17f797d9
      zlim authored
      * Bump ubuntu docker build to bionic
      
      Fixes build dependency for arm64
      Signed-off-by: default avatarZi Shen Lim <zlim.lnx@gmail.com>
      
      * Add Build-Depends: dh-python
      
      Fixes build dependency issue observed on bionic/arm64:
      
      dh: unable to load addon python3: Can't locate Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the Debian::Debhelper::Sequence::python3 module) (@INC contains: /etc/perl /usr/local/lib/aarch64-linux-gnu/perl/5.26.1 /usr/local/share/perl/5.26.1 /usr/lib/aarch64-linux-gnu/perl5/5.26 /usr/share/perl5 /usr/lib/aarch64-linux-gnu/perl/5.26 /usr/share/perl/5.26 /usr/local/lib/site_perl /usr/lib/aarch64-linux-gnu/perl-base) at (eval 9) line 1.
      BEGIN failed--compilation aborted at (eval 9) line 1.
      Signed-off-by: default avatarZi Shen Lim <zlim.lnx@gmail.com>
      
      * Enable arm64 deb packaging
      
      LLVM6.0 is minimum version required for arm64 build. [PR#1512]
      
      [PR#1512] https://github.com/iovisor/bcc/pull/1512Signed-off-by: default avatarZi Shen Lim <zlim.lnx@gmail.com>
      17f797d9
  4. 11 Sep, 2018 1 commit
  5. 10 Sep, 2018 2 commits
  6. 07 Sep, 2018 1 commit
  7. 05 Sep, 2018 1 commit
  8. 04 Sep, 2018 1 commit
  9. 02 Sep, 2018 1 commit
    • olsajiri's avatar
      tools: Skip backward time entries v2 (#1958) · fe26ca97
      olsajiri authored
      * tools: Skip backward time entries in xfsslower
      
      While using xfsslower on RHEL7 we occasionally get
      following screwed up latencies:
      
        # xfsslower
        Tracing XFS operations slower than 1 ms
        TIME     COMM           PID    T BYTES   OFF_KB   LAT(ms) FILENAME
        13:25:03 git            3385   R 62      4704     18446744073708.55 tmp_pack_bDUbwZ
        13:25:03 git            3385   S 0       0           3.05 tmp_idx_Kjb2bW
        ...
      
      The reason for this is that on RHEL7 it's possible to get backward
      timetamp with bpf_ktime_get_ns. This needs to be fixed, but meanwhile
      this fix makes sure the latencies with backward times are skipped.
      
      For the rest of the kernels this is just sanity fix with
      possibly just single compare instruction overhead.
      
      It's temporary workaround for #728.
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      
      * tools: Skip backward time entries in ext4dist
      
      While using ext4dist on RHEL7 we occasionally get
      following screwed up latencies:
      
        # ext4dist
        Tracing ext4 operation latency... Hit Ctrl-C to end.
        ^C
      
        operation = write
                     usecs                         : count     distribution
                         0 -> 1                    : 1134529   |********            |
                         2 -> 3                    : 2777582   |********************|
                         4 -> 7                    : 688014    |****                |
                         8 -> 15                   : 36160     |                    |
                        16 -> 31                   : 698       |                    |
                        32 -> 63                   : 6         |                    |
                        64 -> 127                  : 15        |                    |
                       128 -> 255                  : 7         |                    |
                       256 -> 511                  : 1         |                    |
                       512 -> 1023                 : 0         |                    |
                      1024 -> 2047                 : 0         |                    |
                      2048 -> 4095                 : 2         |                    |
                      4096 -> 8191                 : 1         |                    |
                      8192 -> 16383                : 5         |                    |
                     16384 -> 32767                : 0         |                    |
                     32768 -> 65535                : 0         |                    |
      
          9007199254740992 -> 18014398509481983    : 0         |                    |
         18014398509481984 -> 36028797018963967    : 1         |                    |
      
      The reason for this is that on RHEL7 it's possible to get backward
      timestamp with bpf_ktime_get_ns. This needs to be fixed, but meanwhile
      this fix makes sure the latencies with backward times are skipped.
      
      For the rest of the kernels this is just sanity fix with
      possibly just single compare instruction overhead.
      
      It's temporary workaround for #728.
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      fe26ca97
  10. 31 Aug, 2018 1 commit
  11. 30 Aug, 2018 1 commit
    • Filippos Giannakos's avatar
      Serialize python builds (#1951) · 19bdbfd2
      Filippos Giannakos authored
      Generating sdist for both python2 and python3 at the same time can fail
      as they both use the same temporary files.
      
      Make sure that we generate sdist for each `PYTHON_CMD` sequentially.
      19bdbfd2
  12. 28 Aug, 2018 3 commits
  13. 21 Aug, 2018 1 commit
    • muahao's avatar
      [tools/argdist.py] Fix a wrong place of help info (#1939) · 852e19be
      muahao authored
      argdist -H 'r::__vfs_read(void *file, void *buf, size_t count):size_t
      $entry(count):$latency > 1000000'
      is a wrong example which cann't excute success, because lack of ":" and cann't split field correctly.
      
      So, the right command is:
      
      argdist -H 'r::__vfs_read(void *file, void *buf, size_t count):size_t:
      $entry(count):$latency > 1000000'
      Signed-off-by: default avatarAhao Mu <muahao@linux.alibaba.com>
      852e19be
  14. 17 Aug, 2018 2 commits
  15. 16 Aug, 2018 2 commits
  16. 15 Aug, 2018 3 commits
    • Mike Day's avatar
      provide a parameter to suppress printing a new line at the end of the bytes (#1930) · 49d475f1
      Mike Day authored
      provide a parameter to suppress printing a new line at the end of the bytes.
      existing behavior is not changed.
      49d475f1
    • Teng Qin's avatar
      Merge pull request #1929 from iovisor/yhs_dev · ecfbc749
      Teng Qin authored
      fix a rewriter bug for array subscript
      ecfbc749
    • Yonghong Song's avatar
      fix a rewriter bug for array subscript · eb7b586d
      Yonghong Song authored
      additional fix for issue #1850
      
      for the below case in test_clang.py;
        int test(struct pt_regs *ctx, struct mm_struct *mm) {
            return mm->rss_stat.count[MM_ANONPAGES].counter;
        }
      
      the current rewriter generates:
        int test(struct pt_regs *ctx) {
         struct mm_struct *mm = ctx->di;
            return ({ typeof(atomic_long_t) _val;
                      __builtin_memset(&_val, 0, sizeof(_val));
                      bpf_probe_read(&_val,
                                     sizeof(_val),
                                     (u64)(&mm->rss_stat.count) + (MM_ANONPAGES));
                      _val; }).counter;
        }
      The third argument of bpf_probe_read() is incorrect.
      The correct third argument should be
         (u64)((&mm->rss_stat.count) + (MM_ANONPAGES))
      
      This patch fixed the issue by adding extra parenthesis for the
      outer u64 type casting.
      
        int test(struct pt_regs *ctx) {
         struct mm_struct *mm = ctx->di;
            return ({ typeof(atomic_long_t) _val;
                      __builtin_memset(&_val, 0, sizeof(_val));
                      bpf_probe_read(&_val,
                                     sizeof(_val),
                                     (u64)((&mm->rss_stat.count) + (MM_ANONPAGES)));
                      _val; }).counter;
        }
      Signed-off-by: default avatarYonghong Song <yhs@fb.com>
      eb7b586d
  17. 13 Aug, 2018 2 commits
  18. 09 Aug, 2018 4 commits
    • Teng Qin's avatar
      Add name to program too large error message (#1917) · 5aadf2ed
      Teng Qin authored
      Add name to program too large error message
      5aadf2ed
    • Teng Qin's avatar
      Merge pull request #1918 from jeromemarchand/llcstat · 7bb6a4b1
      Teng Qin authored
      llcstat: print a nicer error message when hardware events are missing
      7bb6a4b1
    • Will Fife's avatar
      Adding Fedora 28 to the list of fedora versions (#1898) · 2ac5e02a
      Will Fife authored
      * Adding Fedora 28 to the list of fedora versions
      
      Looking at the repo location, Fedora 28 appears to be supported as well.  Fixing the documentation to include this.
      
      * Update INSTALL.md
      2ac5e02a
    • Brenden Blanco's avatar
      python3 fixes and testing support (#1916) · a296e1e3
      Brenden Blanco authored
      * python3: check ksymname calls with _assert_is_bytes
      
      Fixes a bytes/string concatenation error when get/fix_syscall_fnname is
      called from a python3 system.
      
      * python3: use env python invocation in tools
      
      In order to facilitate testing, but not necessarily as an example of
      good practice, I am changing the invocation of the test tools to use
      `/usr/bin/env python`, so that we can control which python (2 vs 3)
      gets invoked for the test. On the buildbots, I plan to add an optional
      `ln -s /usr/bin/python3 /usr/local/bin/python` on systems that have
      python3-bcc package built. This way, we get more test coverage. Having a
      cmake mechanism to enable both python2 and python3 testing could be a
      further enhancement.
      
      * tools/memleak: add an explicit stdout.flush to print loop
      
      The stdout flush behavior seems to have changed in python3, breaking one
      of the tests. I think it makes sense to flush stdout at the end of each
      timed interval loop anyway, so adding that to the tool itself.
      
      * tests: add b'' strings and fix dangling handles
      
      Add b'' strings in a few places in the test tools, and fix one dangling
      process handle in the memleak test tool runner.
      a296e1e3
  19. 08 Aug, 2018 1 commit
    • jeromemarchand's avatar
      Miscellaneous fixes (#1914) · b84714a4
      jeromemarchand authored
      * Fix multiple memory access errors
      
      Fixes a buffer overflow in get_pid_exe(), a use-after-free error in
      bcc_usdt_get_probe_argctype() and a possible NULL pointer dereference
      in find_debug_via_debuglink().
      
      * Fix multiple ressource leaks
      
      Leaked file descriptors in bpf_attach_uprobe() and verify_checksum().
      Memory leaks in  Parser::func_add() and bcc_procutils_language().
      
      * fixup! Fix multiple ressource leaks
      b84714a4
  20. 07 Aug, 2018 2 commits
  21. 04 Aug, 2018 1 commit
  22. 03 Aug, 2018 1 commit
    • yonghong-song's avatar
      fix python3 issue for ttysnoop.py (#1912) · e6a166bc
      yonghong-song authored
      Fix issue #1910
      
      Otherwise, we will have a type mismatch like below:
        [root@aborniakFC tools]# ./ttysnoop 1
        Traceback (most recent call last):
        File "./ttysnoop", line 102, in <module>
        b = BPF(text=bpf_text)
        File "/usr/lib/python3.6/site-packages/bcc/__init__.py", line 337, in __init__
        self._trace_autoload()
        File "/usr/lib/python3.6/site-packages/bcc/__init__.py", line 1030, in _trace_autoload
        event=self.fix_syscall_fnname(func_name[8:]),
        File "/usr/lib/python3.6/site-packages/bcc/__init__.py", line 569, in fix_syscall_fnname
        if name.startswith(prefix):
        TypeError: startswith first arg must be bytes or a tuple of bytes, not str
        [root@aborniakFC tools]#
      Signed-off-by: default avatarYonghong Song <yhs@fb.com>
      e6a166bc
  23. 02 Aug, 2018 1 commit
  24. 01 Aug, 2018 1 commit
  25. 30 Jul, 2018 1 commit
  26. 27 Jul, 2018 2 commits
    • Nikita V. Shirokov's avatar
      [trace.py]: allow to use STRCMP helper with binary values (#1900) · 3953c708
      Nikita V. Shirokov authored
      * [trace.py]: allow to use STRCMP helper with binary values
      
      Summary:
      sometimes in probe you want to compare char* w/ some predefined value
      which is not a string. e.g. setsockopt syscall has signature like this:
      sys_setsockopt(int fd, int level, int optname, char* optval, int optlen)
      and if you want to catch where/who is setting up specific value you are
      forced to compare optval against some predefined array. it's not
      possible today w/ trace.py and in this diff i'm adding such ability
      
      Test Plan:
      as example: we want to catch setsockopt when someone is setting up
      IP_TOS equal to 108
      trace.py 'sys_setsockopt(int fd, int level, int optname, char* optval,
      int optlen)(level==0 && optname == 1 && STRCMP("{0x6C,0x00, 0x00,
      0x00}", optval))' -U -M 1 --bin_cmp -v
      
      without this new modifier:
      static inline bool streq_0(char const *ignored, uintptr_t str) {
              char needle[] = "{0x6C,0x00, 0x00, 0x00}";
              char haystack[sizeof(needle)];
              bpf_probe_read(&haystack, sizeof(haystack), (void *)str);
              for (int i = 0; i < sizeof(needle) - 1; ++i) {
                      if (needle[i] != haystack[i]) {
                              return false;
                      }
              }
              return true;
      }
      
      // see needle is qouted above
      
      with:
      
      tatic inline bool streq_0(char const *ignored, uintptr_t str) {
              char needle[] = {0x6C,0x00, 0x00, 0x00};
              char haystack[sizeof(needle)];
              bpf_probe_read(&haystack, sizeof(haystack), (void *)str);
              for (int i = 0; i < sizeof(needle) - 1; ++i) {
                      if (needle[i] != haystack[i]) {
                              return false;
                      }
              }
              return true;
      }
      
      ...
      PID     TID     COMM            FUNC             -
      1855611 1863183 worker          sys_setsockopt   found
      
      * adding example of --bin_cmp flag usage
      3953c708
    • Javier Honduvilla Coto's avatar
      Allow arbitrary hashtable increments. Fixes #1742 (#1897) · 230c9c00
      Javier Honduvilla Coto authored
      * Allow arbitrary hashtable increments. Fixes #1742
      
      Right now incrementing some datastructure's values like maps or histograms can
      be done with some boilerplate[1] or with `increment` which increments a value
      by 1.
      
      This patch allows a second optional parameter to use as the increment.
      
      - [1]:
      ```
      u64 zero = 0, *val;
      val = map.lookup_or_init(&key, &zero);
      (*val) += inc;
      ```
      
      Notes:
      - Some lines in the documentation where changed because of trailing spaces
      deletion
      - The test is quite simple right now
      - Will update the tools to use `increment` in another PR
      
      * CR changes
      230c9c00