1. 02 May, 2018 3 commits
    • Yonghong Song's avatar
      fix compilation error with latest llvm · 806627e3
      Yonghong Song authored
      The clang commit https://reviews.llvm.org/rL331155
      changed the clang::SourceManager function prototype
         SourceRange getExpansionRange(SourceRange Range)
      to
         CharSourceRange getExpansionRange(SourceRange Range)
      and caused the following compilation failure:
      
        /home/yhs/work/bcc/src/cc/frontends/clang/b_frontend_action.cc:
        In member function ‘clang::SourceRange ebpf::ProbeVisitor::expansionRange(clang::SourceRange)’:
        /home/yhs/work/bcc/src/cc/frontends/clang/b_frontend_action.cc:267:58:
        error: could not convert ‘(&(&((ebpf::ProbeVisitor *)this)->ebpf::ProbeVisitor::rewriter_)
               ->clang::Rewriter::getSourceMgr())->clang::SourceManager::getExpansionRange(range)’
        from ‘clang::CharSourceRange’ to ‘clang::SourceRange’
           return rewriter_.getSourceMgr().getExpansionRange(range);
                                                                  ^
        ...
      
      It is hard to find a compatible change which works
      for both old llvm and the latest change. So this patch
      just fixed the problem for clang 7.0.0 and the old code
      is used for clang 6.x and lower.
      Signed-off-by: default avatarYonghong Song <yhs@fb.com>
      806627e3
    • yonghong-song's avatar
      Merge pull request #1724 from pchaigno/detect-ext-ptr-from-ctx · 01c843e7
      yonghong-song authored
      Detect external pointers from context argument
      01c843e7
    • Paul Chaignon's avatar
      a8b4cee4
  2. 01 May, 2018 2 commits
    • Paul Chaignon's avatar
      Detect external pointers from context pointers · b66a9c9b
      Paul Chaignon authored
      The bcc rewriter is currently unable to detect external pointers
      (i.e., to a memory address that requires calls to bpf_probe_read) if
      they are not declared as arguments, e.g., if they are retrieved
      through the context argument.
      For example, although the two following examples translate to the
      same C code in the end (the bcc rewriter translates the first into
      the second), the sk pointer is recognized as an external pointer only
      in the first example.
      
      int test1(struct pt_regs *ctx, struct sock *sk) {
          // sk is correctly recognized as an external pointer.
      }
      int test2(struct pt_regs *ctx) {
          struct sock *sk = (struct sock *)ctx->di;
          // sk is not recognized as an external pointer.
      }
      
      This commit fixes that by detecting member dereferences of the
      context argument (i.e., the first argument of externally visible
      functions). It also works for the TRACEPOINT_PROBE macro.
      b66a9c9b
    • Paul Chaignon's avatar
  3. 30 Apr, 2018 7 commits
  4. 29 Apr, 2018 6 commits
  5. 28 Apr, 2018 1 commit
  6. 27 Apr, 2018 5 commits
  7. 26 Apr, 2018 9 commits
  8. 25 Apr, 2018 4 commits
  9. 24 Apr, 2018 3 commits