- 13 Sep, 2021 40 commits
-
-
Michael Straube authored
Remove unused function rtl8188e_clone_haldata(). Signed-off-by:
Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20210906190223.11396-39-straube.linux@gmail.comSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Michael Straube authored
Remove free_hal_data from hal_ops and remove its wrapper rtw_hal_free_data(). Call rtl8188e_free_hal_data() directly instead. Signed-off-by:
-
Michael Straube authored
Remove hal_notch_filter from hal_ops and remove its wrapper rtw_hal_notch_filter(). Call hal_notch_filter_8188e() directly instead. Signed-off-by:
-
Michael Straube authored
Remove empty function rtl8188e_stop_thread() and related code. Signed-off-by:
-
Michael Straube authored
Remove empty function rtl8188e_start_thread() and related code. Signed-off-by:
-
Michael Straube authored
Remove AntDivCompareHandler from hal_ops and remove its wrapper rtw_hal_antdiv_rssi_compared(). Call AntDivCompare8188E() directly instead. Signed-off-by:
-
Michael Straube authored
Remove AntDivBeforeLinkHandler from hal_ops and remove its wrapper rtw_hal_antdiv_before_linked(). Call AntDivBeforeLink8188E() directly instead. Signed-off-by:
-
Michael Straube authored
The local variable badworden is set to a new value immediately after an assignment. Remove the useless assignment and initialization. Signed-off-by:
-
Michael Straube authored
Remove Efuse_WordEnableDataWrite from hal_ops and remove its wrapper Efuse_WordEnableDataWrite(). Call rtl8188e_Efuse_WordEnableDataWrite() directly instead. Signed-off-by:
-
Michael Straube authored
Remove Efuse_PgPacketWrite from hal_ops and remove its wrapper Efuse_PgPacketWrite(). Call rtl8188e_Efuse_PgPacketWrite() directly instead. Signed-off-by:
-
Michael Straube authored
Remove Efuse_PgPacketRead from hal_ops and remove its wrapper Efuse_PgPacketRead(). Call rtl8188e_Efuse_PgPacketRead() directly instead. Signed-off-by:
-
Michael Straube authored
Remove empty comments. Signed-off-by:
-
Michael Straube authored
Remove EfuseGetCurrentSize from hal_ops and remove its wrapper Efuse_GetCurrentSize(). Call rtl8188e_EfuseGetCurrentSize() directly instead. Signed-off-by:
-
Michael Straube authored
Remove EFUSEGetEfuseDefinition from hal_ops and remove its wrapper EFUSE_GetEfuseDefinition(). Call rtl8188e_EFUSE_GetEfuseDefinition() directly instead. Signed-off-by:
-
Michael Straube authored
Remove ReadEFuse from hal_ops and remove its wrapper efuse_ReadEFuse(). Call rtl8188e_ReadEFuse() directly instead. Signed-off-by:
-
Michael Straube authored
Remove wrapper Efuse_PowerSwitch() and call rtl8188e_EfusePowerSwitch() directly. Signed-off-by:
-
Michael Straube authored
Rename hal_EfusePowerSwitch_RTL8188E() to get rid of a wrapper. hal_EfusePowerSwitch_RTL8188E() -> rtl8188e_EfusePowerSwitch(). Signed-off-by:
-
Michael Straube authored
Remove EfusePowerSwitch from hal_ops and call rtl8188e_EfusePowerSwitch() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_get_wifi_status from hal_ops and remove its wrapper rtw_hal_sreset_get_wifi_status(). Call sreset_get_wifi_status() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_linked_status_check from hal_ops and remove its wrapper rtw_hal_sreset_linked_status_check(). Call rtl8188e_sreset_linked_status_check() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_xmit_status_check from hal_ops and remove its wrapper rtw_hal_sreset_xmit_status_check(). Call rtl8188e_sreset_xmit_status_check() directly instead. Signed-off-by:
-
Michael Straube authored
Remove silentreset from hal_ops and remove its wrapper rtw_hal_sreset_reset(). Call rtl8188e_silentreset_for_specific_platform() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_reset_value from hal_ops and remove its wrapper rtw_hal_sreset_reset_value(). Call sreset_reset_value() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_init_value from hal_ops and remove its wrapper rtw_hal_sreset_init(). Call sreset_init_value() directly instead. Signed-off-by:
-
Michael Straube authored
Remove hal_power_on from hal_ops and remove its wrapper rtw_hal_power_on(). Call rtl8188eu_InitPowerOn() directly instead. Signed-off-by:
-
Michael Straube authored
Remove Add_RateATid from hal_ops and remove its wrapper rtw_hal_add_ra_tid(). Call rtl8188e_Add_RateATid() directly instead. Signed-off-by:
-
Michael Straube authored
HAL_USB_SELECT_SUSPEND and HAL_MAX_ID are both unused, so enum hal_intf_ps_func can be removed. Signed-off-by:
-
Michael Straube authored
Remove set_channel_handler from hal_ops and remove its wrapper rtw_hal_set_chan(). Call PHY_SwChnl8188E() directly instead. Signed-off-by:
-
Michael Straube authored
Remove set_bwmode_handler from hal_ops and remove its wrapper rtw_hal_set_bwmode(). Call PHY_SetBWMode8188E() directly instead. Signed-off-by:
-
Michael Straube authored
Remove hal_dm_watchdog from hal_ops and remove its wrapper rtw_hal_dm_watchdog(). Call rtl8188e_HalDmWatchDog directly instead. Signed-off-by:
-
Michael Straube authored
Remove interface_ps_func from hal_ops from hal_ops and remove its wrapper rtw_hal_intf_ps_func() and the unused rtl8188eu_ps_func(). Signed-off-by:
-
Michael Straube authored
Remove unused function rtw_interface_ps_func(). Signed-off-by:
-
Michael Straube authored
Remove the following empty functions. Hal_InitChannelPlan() Hal_CustomizeByCustomerID_8188EU() _InitBeaconMaxError() Signed-off-by:
-
Michael Straube authored
Remove SetHalODMVarHandler from hal_ops and remove its wrapper rtw_hal_set_odm_var(). Call rtl8188e_SetHalODMVar() directly instead. Signed-off-by:
-
Michael Straube authored
Remove dm_deinit from hal_ops and remove its wrapper rtw_hal_dm_deinit(). Call rtl8188e_deinit_dm_priv() directly instead. Signed-off-by:
-
Michael Straube authored
Remove dm_init from hal_ops and remove its wrapper rtw_hal_dm_init(). Call rtl8188e_init_dm_priv() directly instead. Signed-off-by:
-
Michael Straube authored
Remove DeInitSwLeds from hal_ops and remove its wrapper rtw_hal_sw_led_deinit(). Call rtl8188eu_DeInitSwLeds() directly instead. Signed-off-by:
-
Michael Straube authored
Remove InitSwLeds from hal_ops and remove its wrapper rtw_hal_sw_led_init(). Call rtl8188eu_InitSwLeds() directly instead. Signed-off-by:
-
Fabio M. De Francesco authored
Remove _enter_critical_mutex() and _exit_critical_mutex(). They are unnecessary wrappers, respectively to mutex_lock_interruptible() and to mutex_unlock(). They also have an odd interface that takes an unused argument named pirqL of type unsigned long. The original code enters the critical section if the mutex API is interrupted while waiting to acquire the lock; therefore it could lead to a race condition. Use mutex_lock() because it is uninterruptible and so avoid that above-mentioned potential race condition. Tested-by:
Pavel Skripkin <paskripkin@gmail.com> Reviewed-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Link: https://lore.kernel.org/r/20210828113656.6963-1-fmdefrancesco@gmail.comSigned-off-by:
-
Pavel Skripkin authored
While testing Fabio's patch I hit lockdep warning about possible deadlock: [ 252.063305] WARNING: possible recursive locking detected [ 252.063642] 5.14.0+ #9 Tainted: G C [ 252.063946] -------------------------------------------- [ 252.064282] ip/335 is trying to acquire lock: [ 252.064560] ffff888009ebad28 (pmutex){+.+.}-{4:4}, at: usbctrl_vendorreq+0xc5/0x4a0 [r8188eu] [ 252.065168] [ 252.065168] but task is already holding lock: [ 252.065536] ffffffffc021b3b8 (pmutex){+.+.}-{4:4}, at: netdev_open+0x3a/0x5f [r8188eu] [ 252.066085] [ 252.066085] other info that might help us debug this: [ 252.066494] Possible unsafe locking scenario: [ 252.066494] [ 252.066866] CPU0 [ 252.067025] ---- [ 252.067184] lock(pmutex); [ 252.067367] lock(pmutex); There is one problem with this warning: there is no pmutex in this driver, *BUT* all mutexes are initialized via private _rtw_mutex_init API, which had struct mutex *pmutex argument. So, all mutexes in this driver had same name in lockdep map. Of course, lockdep will complain about any nested locking. Fix it by open-coding _rtw_mutex_{init,free} wrappers, because we do not need them at all. Cc: Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by:
-
