- 13 Sep, 2021 40 commits
-
-
Larry Finger authored
These rwo conditional compile symbols are explicitely defined. As a result, their included code is always compiled. They could be converted to Kconfig symbols; however, my experience with this driver in a GitHub repo is that many users of the device have it built into a SOC or SBC that they wish to use as an access point. As a result, CONFIG_88EU_APMODE would need to be selected. Thuse it should be built in. There have also been many users the wish to establish peer-to-peer networks with this device. For this reason, I am also proposing that CONFIG_88EU_P2P be automatically included. Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Link: https://lore.kernel.org/r/20210909165809.12634-1-Larry.Finger@lwfinger.netSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
There's a funny "loop" in rtl8188eu_xmitframe_complete. It looks like do { ... some commands... break; } while (1); Remove it. Acked-by:Michael Straube <straube.linux@gmail.com> Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20210908085747.32254-4-martin@kaiser.cxSigned-off-by:
-
Martin Kaiser authored
The RTW_SUSPEND_LOCK_NAME define is not used. Remove it. Acked-by:
-
Martin Kaiser authored
There's no rtw_write_scsi function in this driver. Remove its prototype. Acked-by:
-
Michael Straube authored
Remove unused function Hal_ProSetCrystalCap(). Acked-by:
Phillip Potter <phil@philpotter.co.uk> Signed-off-by:
-
Colin Ian King authored
Variable hoffset is being assigned values but it is never being used. The variable is redundant and can be removed. Acked-by:
Colin Ian King <colin.king@canonical.com> Addresses-Coverity: ("Unused value") Link: https://lore.kernel.org/r/20210907085302.10672-1-colin.king@canonical.comSigned-off-by:
-
Greg Kroah-Hartman authored
Using a struct class, a cdev, and another device just for a single minor device is total overkill. Just use a dynamic misc device instead, saving lots of logic and memory. Cc: Jacob Feder <jacobsfeder@gmail.com> Cc: Lee Jones <lee.jones@linaro.org> Cc: Muhammad Usama Anjum <musamaanjum@gmail.com> Link: https://lore.kernel.org/r/YTdPvBgKW6cKYrvb@kroah.comSigned-off-by:
-
Greg Kroah-Hartman authored
Using a struct class, a cdev, and another device just for a single minor device is total overkill. Just use a dynamic misc device instead, saving lots of logic and memory. Cc: Nicolas Saenz Julienne <nsaenz@kernel.org> Cc: Stefan Wahren <stefan.wahren@i2se.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: Ojaswin Mujoo <ojaswin98@gmail.com> Cc: Phil Elwell <phil@raspberrypi.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Link: https://lore.kernel.org/r/20210907115045.2206083-1-gregkh@linuxfoundation.orgSigned-off-by:
-
Michael Straube authored
Remove UpdateHalRAMask8188EUsb from hal_ops and call UpdateHalRAMask8188EUsb() directly instead. Signed-off-by:
-
Michael Straube authored
Remove SetBeaconRelatedRegistersHandler from hal_ops and remove its wrapper rtw_hal_bcn_related_reg_setting(). Call SetBeaconRelatedRegisters8188EUsb() directly instead. Signed-off-by:
-
Michael Straube authored
Remove unused function rtl8188e_clone_haldata(). Signed-off-by:
-
Michael Straube authored
Remove free_hal_data from hal_ops and remove its wrapper rtw_hal_free_data(). Call rtl8188e_free_hal_data() directly instead. Signed-off-by:
-
Michael Straube authored
Remove hal_notch_filter from hal_ops and remove its wrapper rtw_hal_notch_filter(). Call hal_notch_filter_8188e() directly instead. Signed-off-by:
-
Michael Straube authored
Remove empty function rtl8188e_stop_thread() and related code. Signed-off-by:
-
Michael Straube authored
Remove empty function rtl8188e_start_thread() and related code. Signed-off-by:
-
Michael Straube authored
Remove AntDivCompareHandler from hal_ops and remove its wrapper rtw_hal_antdiv_rssi_compared(). Call AntDivCompare8188E() directly instead. Signed-off-by:
-
Michael Straube authored
Remove AntDivBeforeLinkHandler from hal_ops and remove its wrapper rtw_hal_antdiv_before_linked(). Call AntDivBeforeLink8188E() directly instead. Signed-off-by:
-
Michael Straube authored
The local variable badworden is set to a new value immediately after an assignment. Remove the useless assignment and initialization. Signed-off-by:
-
Michael Straube authored
Remove Efuse_WordEnableDataWrite from hal_ops and remove its wrapper Efuse_WordEnableDataWrite(). Call rtl8188e_Efuse_WordEnableDataWrite() directly instead. Signed-off-by:
-
Michael Straube authored
Remove Efuse_PgPacketWrite from hal_ops and remove its wrapper Efuse_PgPacketWrite(). Call rtl8188e_Efuse_PgPacketWrite() directly instead. Signed-off-by:
-
Michael Straube authored
Remove Efuse_PgPacketRead from hal_ops and remove its wrapper Efuse_PgPacketRead(). Call rtl8188e_Efuse_PgPacketRead() directly instead. Signed-off-by:
-
Michael Straube authored
Remove empty comments. Signed-off-by:
-
Michael Straube authored
Remove EfuseGetCurrentSize from hal_ops and remove its wrapper Efuse_GetCurrentSize(). Call rtl8188e_EfuseGetCurrentSize() directly instead. Signed-off-by:
-
Michael Straube authored
Remove EFUSEGetEfuseDefinition from hal_ops and remove its wrapper EFUSE_GetEfuseDefinition(). Call rtl8188e_EFUSE_GetEfuseDefinition() directly instead. Signed-off-by:
-
Michael Straube authored
Remove ReadEFuse from hal_ops and remove its wrapper efuse_ReadEFuse(). Call rtl8188e_ReadEFuse() directly instead. Signed-off-by:
-
Michael Straube authored
Remove wrapper Efuse_PowerSwitch() and call rtl8188e_EfusePowerSwitch() directly. Signed-off-by:
-
Michael Straube authored
Rename hal_EfusePowerSwitch_RTL8188E() to get rid of a wrapper. hal_EfusePowerSwitch_RTL8188E() -> rtl8188e_EfusePowerSwitch(). Signed-off-by:
-
Michael Straube authored
Remove EfusePowerSwitch from hal_ops and call rtl8188e_EfusePowerSwitch() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_get_wifi_status from hal_ops and remove its wrapper rtw_hal_sreset_get_wifi_status(). Call sreset_get_wifi_status() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_linked_status_check from hal_ops and remove its wrapper rtw_hal_sreset_linked_status_check(). Call rtl8188e_sreset_linked_status_check() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_xmit_status_check from hal_ops and remove its wrapper rtw_hal_sreset_xmit_status_check(). Call rtl8188e_sreset_xmit_status_check() directly instead. Signed-off-by:
-
Michael Straube authored
Remove silentreset from hal_ops and remove its wrapper rtw_hal_sreset_reset(). Call rtl8188e_silentreset_for_specific_platform() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_reset_value from hal_ops and remove its wrapper rtw_hal_sreset_reset_value(). Call sreset_reset_value() directly instead. Signed-off-by:
-
Michael Straube authored
Remove sreset_init_value from hal_ops and remove its wrapper rtw_hal_sreset_init(). Call sreset_init_value() directly instead. Signed-off-by:
-
Michael Straube authored
Remove hal_power_on from hal_ops and remove its wrapper rtw_hal_power_on(). Call rtl8188eu_InitPowerOn() directly instead. Signed-off-by:
-
Michael Straube authored
Remove Add_RateATid from hal_ops and remove its wrapper rtw_hal_add_ra_tid(). Call rtl8188e_Add_RateATid() directly instead. Signed-off-by:
-
Michael Straube authored
HAL_USB_SELECT_SUSPEND and HAL_MAX_ID are both unused, so enum hal_intf_ps_func can be removed. Signed-off-by:
-
Michael Straube authored
Remove set_channel_handler from hal_ops and remove its wrapper rtw_hal_set_chan(). Call PHY_SwChnl8188E() directly instead. Signed-off-by:
-
Michael Straube authored
Remove set_bwmode_handler from hal_ops and remove its wrapper rtw_hal_set_bwmode(). Call PHY_SetBWMode8188E() directly instead. Signed-off-by:
-
Michael Straube authored
Remove hal_dm_watchdog from hal_ops and remove its wrapper rtw_hal_dm_watchdog(). Call rtl8188e_HalDmWatchDog directly instead. Signed-off-by:
-
