Commits · aadca61e0d1eb58f60c44ecaaaad0f68ec7d7e7a · Levin Zimmermann / erp5

29 Dec, 2007 3 commits

Compute loop invariants outside of loop. · aadca61e

Vincent Pelletier authored Dec 29, 2007

Iterate over object ids instead of over object values.
Instead of using find, then spliting string, first split and compare with list items.
Check that *all* subparts of cell id are ints, not just the first one.
Remove unneeded value assignment.
Fix comment.
Clarify "try" structure: append is what must happen if no error is raised.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18557 20353a03-c40f-0410-a6d1-a30d3c3de9de

aadca61e

Use list's "append" method. · e507f8da

Vincent Pelletier authored Dec 29, 2007


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18556 20353a03-c40f-0410-a6d1-a30d3c3de9de

e507f8da

(Partialy) Update comments and coding style. · b009df74

Vincent Pelletier authored Dec 29, 2007


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18555 20353a03-c40f-0410-a6d1-a30d3c3de9de

b009df74

28 Dec, 2007 19 commits

correct some of the indentation problems · f5a732f7

Fabien Morin authored Dec 28, 2007


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18554 20353a03-c40f-0410-a6d1-a30d3c3de9de

f5a732f7

just cutting line to be less than 80 characters · ece02f31

Fabien Morin authored Dec 28, 2007


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18553 20353a03-c40f-0410-a6d1-a30d3c3de9de

ece02f31

Remove test_renameObjectsPreservesUid: it is not a required feature. What is... · 0b7ef6ad

Vincent Pelletier authored Dec 28, 2007

Remove test_renameObjectsPreservesUid: it is not a required feature. What is costly in renaming an object is updating all relations pointing at (or traversing) renamed object. Updating the uid in category table is "just" a consequence from this, and will be done anyway - even if uid is the same.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18552 20353a03-c40f-0410-a6d1-a30d3c3de9de

0b7ef6ad

Revert previous patch: no error must be emmited if codification path is found... · 3351ae39

Vincent Pelletier authored Dec 28, 2007

Revert previous patch: no error must be emmited if codification path is found but is an empty string.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18551 20353a03-c40f-0410-a6d1-a30d3c3de9de

3351ae39

vault_path can be an empty string, which would causes category path to have a... · e88bc8a7

Vincent Pelletier authored Dec 28, 2007

vault_path can be an empty string, which would causes category path to have a trailing slash, which is invalid with current category traversal.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18550 20353a03-c40f-0410-a6d1-a30d3c3de9de

e88bc8a7

Fix a race condition which can lead cells to being uncataloged when cell range is modified. · 2713e0aa

Vincent Pelletier authored Dec 28, 2007

It also fixes ZSQLCatalog from emmiting false "duplicate uid" warnings in this case.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18549 20353a03-c40f-0410-a6d1-a30d3c3de9de

2713e0aa

Use iteritems to get rid of some property & key lookups. · 544fcdb2
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18548 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
544fcdb2
Modifications to include height and width scaling · 53cb9c2d
Mame Coumba Sall authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18547 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
53cb9c2d
Do not put any entry in movement dict when there is no movement. · 295d27c0
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18546 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
295d27c0
Avoid unneeded dictionary key lookups (use a temporary variable instead). · 43e118b7
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18545 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
43e118b7
Avoid creating a PersistentMapping instance to just overwrite it at function end. · 4da01688
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18544 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
4da01688
new_index contains just one entry, so remove a useless level of nesting. · 42775c10
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18543 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
42775c10

"movement" dictionnary always contains just one key, base_id, so remove this... · 5a0ec5a4

Vincent Pelletier authored Dec 28, 2007

"movement" dictionnary always contains just one key, base_id, so remove this useless level of nesting.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18542 20353a03-c40f-0410-a6d1-a30d3c3de9de

5a0ec5a4

Use dictionary getter (returns None if key is not found). · b8bb0758

Vincent Pelletier authored Dec 28, 2007

fix coding style.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18541 20353a03-c40f-0410-a6d1-a30d3c3de9de

b8bb0758

Move test which is invariant at this level one level higher. · 740b636f
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18540 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
740b636f
support __getitem__ with negative value except -1. · 8d1432c6
Kazuhiko Shiozaki authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18539 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
8d1432c6
restrictedTraverse is overkill to fetch a direct subobject. · 46fbe062
Vincent Pelletier authored Dec 28, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18538 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
46fbe062

Check that renaming objects preserve their uid. · 3c9ca89c

Vincent Pelletier authored Dec 28, 2007

Check that renaming an object with a subobject updates subobject path.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18537 20353a03-c40f-0410-a6d1-a30d3c3de9de

3c9ca89c

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18536 20353a03-c40f-0410-a6d1-a30d3c3de9de · 3b7f9450
Mame Coumba Sall authored Dec 28, 2007
3b7f9450

27 Dec, 2007 8 commits

this modification is really needed for Zope 2.7. · 71725822
Kazuhiko Shiozaki authored Dec 27, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18535 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
71725822
implement __nonzero__() for faster boolean check. · 1ef34070
Kazuhiko Shiozaki authored Dec 27, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18533 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
1ef34070
updateLocalRolesOnSecurityGroups needs to be unrestricted. · e371094e
Yoshinori Okuji authored Dec 27, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18532 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
e371094e

AppliedRule's expand needs to be unrestricted. · 2c361026

Yoshinori Okuji authored Dec 27, 2007

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18531 20353a03-c40f-0410-a6d1-a30d3c3de9de

2c361026

use VARBINARY instead of VARCHAR for utf8 database. · 7c78fde9
Kazuhiko Shiozaki authored Dec 27, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18530 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
7c78fde9
use reversely linked list for storing workflow history to reduce data size. · c7815a4b
Kazuhiko Shiozaki authored Dec 27, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18529 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
c7815a4b

Grab portal once and use it as acquitision context. · 88a10a5f

Vincent Pelletier authored Dec 27, 2007

Refresh worklist SQL cache as it's now safe to call this method even if required scripts are not available (it's a noop then).


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18528 20353a03-c40f-0410-a6d1-a30d3c3de9de

88a10a5f

"owner" column must not be None anymore if owner do not have view permission,... · 20ed0d00

Vincent Pelletier authored Dec 27, 2007

"owner" column must not be None anymore if owner do not have view permission, but '' (empty string).


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18527 20353a03-c40f-0410-a6d1-a30d3c3de9de

20ed0d00

26 Dec, 2007 10 commits

Document finalizeMessageExecution. · 61aecbbe

Vincent Pelletier authored Dec 26, 2007

Cause partial execution failure to abort transaction.
When some messages succeeded and some failed, make successful messages available for immediate processing, and make failed messages go through usual conditions (involves postponing them).
This fixes a stupid mistake in makeMessageListAvailable invoquation on delay_uid_list instead of [uid] in finalizeMessageExecution..

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18526 20353a03-c40f-0410-a6d1-a30d3c3de9de

61aecbbe

Modified scripts (from context bar only) to update the selection with the last... · 0180d6b6

Rafael Monnerat authored Dec 26, 2007

Modified scripts (from context bar only) to update the selection with the last (un)checked itens from listbox.

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18525 20353a03-c40f-0410-a6d1-a30d3c3de9de

0180d6b6

Improved fast input test. · f8496898

Rafael Monnerat authored Dec 26, 2007

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18522 20353a03-c40f-0410-a6d1-a30d3c3de9de

f8496898

Changed Fast Input actions from object_action or object_exchange to object_fast_input. · f8628de6
Rafael Monnerat authored Dec 26, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18521 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
f8628de6

Make refreshWorklistCache safe to call even if the required scripts are not... · 0afaa9ff

Vincent Pelletier authored Dec 26, 2007

Make refreshWorklistCache safe to call even if the required scripts are not present. Also, it saves some acquisition lookups in the process.


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18520 20353a03-c40f-0410-a6d1-a30d3c3de9de

0afaa9ff

Changed Fast Input actions from object_action or object_exchange to object_fast_input. · 8faa51ac
Rafael Monnerat authored Dec 26, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18519 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
8faa51ac

Exclude Base Domain as well. · 014b08af

Yoshinori Okuji authored Dec 26, 2007

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18518 20353a03-c40f-0410-a6d1-a30d3c3de9de

014b08af

Owner column cannot be NONE any longer, so transform NONE into empty string when indexing. · bb857dac
Vincent Pelletier authored Dec 26, 2007
```
git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18517 20353a03-c40f-0410-a6d1-a30d3c3de9de
```
bb857dac

Make owner column NOT NULL. · afdb9858

Vincent Pelletier authored Dec 26, 2007

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18515 20353a03-c40f-0410-a6d1-a30d3c3de9de

afdb9858

Make user owner cannot be NULL. · ae172764

Vincent Pelletier authored Dec 26, 2007

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@18514 20353a03-c40f-0410-a6d1-a30d3c3de9de

ae172764