Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !438

Merged
Created Oct 20, 2022 by Rafael Monnerat@rafael👻Owner

Partial re-implementation of the Parameter editor

  • Overview 7
  • Commits 38
  • Changes 93

The re-implementation here is based on make 2 points:

  • Replace expandSchema to use ref-parser library
  • Replace tv4 by cfworker json schema (validator)

The selection of the validator to replace tv4, consider 2 criteria:

  • Don't use eval or anything that requires changes on CSP (like unsafe-eval)
  • Has the least amount of errors as possible (more important then speed)
  • Is ranked on well known on benchmark tests

See: https://github.com/ebdrup/json-schema-benchmark

This refactoring includes a large set of tests and fixes for parameter field (ie: required)

This MR replaces and extends !440 (closed)

Edited Nov 01, 2022 by Rafael Monnerat
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: parameter-editor-refactor
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7