Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !791

Merged
Created Jun 12, 2025 by Rafael Monnerat@rafael👻Owner

Revert "slapgrid & SlapTool: Avoid POST if software release state is already as expected"

  • Overview 0
  • Commits 1
  • Changes 4

This reverts commit e28916c9 (in general).

The optimization introduced by that change is no longer necessary following commit b8d962a9 ("grid/slapgrid.py: reduce number of installation.available calls"). Since API calls are now less frequent, avoiding the POST to the master offers little benefit.

Worse, skipping the POST can now cause issues: if the software is reconstructed and its state transitions to "building", it may never be reported back as "available" in some race conditions, leading to incorrect or outdated local state.

Edited Jun 24, 2025 by Rafael Monnerat
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: rev-e28916c9
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7