Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
S slapos.core
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Labels
    • Labels
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • slapos.core
  • Merge requests
  • !792

Merged
Created Jun 12, 2025 by Rafael Monnerat@rafael👻Owner

Revert "slap: Use CacheControl on client side to respect HTTP cache headers"

  • Overview 1
  • Commits 1
  • Changes 2

This reverts commit 16ca1f2c455c710c0c202e0859a69bdfa3e4fe92.

While CacheControl correctly implements HTTP caching, it does not fulfill the original intent of supporting the state-if-error use case. Improvements to keep running nodes while master is off, has since been implemented in a more effective and SlapOS-specific manner, making this change redundant.

Additionally, CacheControl introduces issues when processing If-Modified-Since headers, causing the cache to be preserved in unexpected ways.

As we do not plan to rely on HTTP caching for the new API, this change removes CacheControl to resolve the issues introduced—without sacrificing any functionality, since the cache was not meaningfully used.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: drop-cachecontrol
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7