• Kirill Smelkov's avatar
    slapgrid: Do not leak file descriptors to subprocesses when running 'node software' · 2f5ade0a
    Kirill Smelkov authored
    Some context: I'm trying to build Go 1.10 under slapos and get failures
    like:
    
    	ok   os      0.782s
    	PASS
    	testing: can't write /tmp/go-build511454695/b682/testlog.txt: write /tmp/go-build511454695/b682/testlog.txt: broken pipe
    	FAIL os/exec 0.947s
    	...
    	ok   cmd/vet/internal/cfg    0.002s
    	2018/04/03 18:13:29 Failed: exit status 1
    	golang1.10: Command failed with exit code 1:   cd src && ls -l /proc/self/fd && ./all.bash && cp -alf .. /srv/slapgrid/slappart5/srv/runner/software/099a7368550e95d120639cb03b6d47c8/parts/golang1.10
    	golang1.10: Compilation error. The package is left as is at /srv/slapgrid/slappart5/srv/runner/software/099a7368550e95d120639cb03b6d47c8/parts/golang1.10__compile__/go where you can inspect what went wrong
    	While:
    	  Installing golang1.10.
    	Error: System error
    
    This was traced to https://github.com/golang/go/issues/24285, which in turn was
    traced by me to the fact that golang os/...
    2f5ade0a