This test lacks the use case of same user transaction

 The Base.reindexObject is not called directly anymore, so patch a deeper level

assertNotEquals is deprecated since 3.2 (see https://docs.python.org/3.7/library/unittest.html#deprecated-aliases)
This is a followup of 175b5788

/reviewed-on nexedi/slapos.core!81

`test_one_failing_daemon_in_service_will_bang_with_watchdog` often fail with:

```
======================================================================
FAIL: test_one_failing_daemon_in_service_will_bang_with_watchdog (slapos.tests.slapgrid.TestSlapgridCPWithMasterWatchdog)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/slapgrid/slappart9/srv/testnode/bpy/inst/test0-0/parts/slapos.core/slapos/tests/slapgrid.py", line 907, in test_one_failing_daemon_in_service_will_bang_with_watchdog
    'etc', 'software_release', 'worked', '.slapos-retention-lock-delay'])
  File "/srv/slapgrid/slappart9/srv/testnode/bpy/soft/5082e1741ad09c0910ec59bf9feae300/eggs/six-1.11.0-py2.7.egg/six.py", line 673, in assertCountEqual
    return getattr(self, _assertCountEqual)(*args, **kwargs)
AssertionError: Element counts were not equal:
First has 1, Second has 0:  'crashed'
First has 1, Second has 0:  'launched'
```

This test uses a service that will create files `launched` and `crashed` files
when running, and just after telling supervisor to start the service test
inspects the directory content.
If service had time to start, then files are created, otherwise they are not.

Change the service to wait for a delay before creating the files to reduce the
change of race condition here.

/reviewed-on nexedi/slapos.core!82

Slapos proxy was not really deleting the software, just removing it from its database but not telling the node that requester requested deletion.

As a result, node was not destroying the software and leaving the software folder around.

These changes are about telling the node that requester wanted destruction of software, so that node really delete the folder.

/reviewed-on nexedi/slapos.core!76

Tests are sometimes failing with:

```
======================================================================
FAIL: testForwardToMasterInList (slapos.tests.slapproxy.TestMultiMasterSupport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/srv/slapgrid/slappart9/srv/testnode/byq/inst/test0-0/parts/slapos.core/slapos/tests/slapproxy/__init__.py", line 1003, in setUp
    self.startExternalProxy()
  File "/srv/slapgrid/slappart9/srv/testnode/byq/inst/test0-0/parts/slapos.core/slapos/tests/slapproxy/__init__.py", line 1050, in startExternalProxy
    self.fail('Could not start external proxy.')
AssertionError: Could not start external proxy.

```

especially on `COMP-2203-3Nodes-ERP5PROJECT2`. I logged on that machine and check the tests, it was really a problem that this slapproxy needs more than the `(20 * .1) = 2` seconds this tests waits before concluding that slap proxy could not start.

Change the waiting loop to wait more each time. With this approach the max waiting time is 20 seconds.

/reviewed-on nexedi/slapos.core!83

/reviewed-on nexedi/slapos.core!85

this XXX comment no longer apply

put back `related_predecessor_but_with_different_title_than_catalog_title` which was removed by commit 85c7fb26

/reviewed-on nexedi/slapos.core!80

SlapOS test is too verbose, see http://community.slapos.org/test_result_module/20181211-426F13FE/6 as an example. The main goal of this work is to make this easier to read.

Other improvements:
 * introduce `subprocess32` on python2 to use new subprocess features on python2
 * honor `SLAPOS_TEST_DEBUG` environment variable to output logs and also enable debugging utilities ( unittest's `Ctrl+C` handler )


/reviewed-on nexedi/slapos.core!73

now that we are using version 12
Also, rename the dump as "current", so that it's more obvious that
unlike the database_dump_version_10.sql file from the same folder that's
supposed to be a fixed version, this one is for the current version and
needs to be updated each time.

proxy was just removing the software from database when destruction was
requested. Instead, keep it as requested_state = "destroyed" and return
this information to the node, so that nodes properly destroy the
software.

Upgrade Decision which are not closed are added to ticket listbox
Closed ticket are now hidden

/reviewed-on nexedi/slapos.core!75

Use logger which is only enabled in debug mode.
Also don't print tips when executing this file, describe it in the
docstring instead.

Especially, don't use None which cause output on the console.

to keep tests silent.

On python2, this uses subprocess32, which backports DEVNULL (and
default setting of closing file descriptors).

subprocess32 backports the good things from python3's subprocess and is
recommended on https://docs.python.org/2/library/subprocess.html

it's now configured in tests/__init__.py

When running tests we don't want to clutter the output with logs.
Environment variable SLAPOS_TEST_DEBUG can be set to restore the
verbosity

Instead of printing when passed log=True, always log at DEBUG level,
application can decide what to do with these logs.

Upgrade Decision which are not closed are added to ticket listbox
Closed ticket are now hidden

This will let the connection parameters with multilines value be correctly displayed.

I also fixed the linter.

/reviewed-on nexedi/slapos.core!74

slapos_crm: testSlapOSCRMSkins: The order of the elements of portal_catalog are not always the same.

Probably incomplete as we need to check for activities.