1. 07 Jan, 2019 1 commit
  2. 02 Jan, 2019 5 commits
  3. 28 Dec, 2018 25 commits
  4. 27 Dec, 2018 5 commits
    • Thomas Gambier's avatar
      CLEANUP: use assertNotEqual instead of assertNotEquals · 812d00c4
      Thomas Gambier authored
      assertNotEquals is deprecated since 3.2 (see https://docs.python.org/3.7/library/unittest.html#deprecated-aliases)
      This is a followup of 175b5788
      812d00c4
    • Jérome Perrin's avatar
    • Jérome Perrin's avatar
      tests/slapgrid: make test more deterministic · d4d89cce
      Jérome Perrin authored
      `test_one_failing_daemon_in_service_will_bang_with_watchdog` often fail with:
      
      ```
      ======================================================================
      FAIL: test_one_failing_daemon_in_service_will_bang_with_watchdog (slapos.tests.slapgrid.TestSlapgridCPWithMasterWatchdog)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/srv/slapgrid/slappart9/srv/testnode/bpy/inst/test0-0/parts/slapos.core/slapos/tests/slapgrid.py", line 907, in test_one_failing_daemon_in_service_will_bang_with_watchdog
          'etc', 'software_release', 'worked', '.slapos-retention-lock-delay'])
        File "/srv/slapgrid/slappart9/srv/testnode/bpy/soft/5082e1741ad09c0910ec59bf9feae300/eggs/six-1.11.0-py2.7.egg/six.py", line 673, in assertCountEqual
          return getattr(self, _assertCountEqual)(*args, **kwargs)
      AssertionError: Element counts were not equal:
      First has 1, Second has 0:  'crashed'
      First has 1, Second has 0:  'launched'
      ```
      
      This test uses a service that will create files `launched` and `crashed` files
      when running, and just after telling supervisor to start the service test
      inspects the directory content.
      If service had time to start, then files are created, otherwise they are not.
      
      Change the service to wait for a delay before creating the files to reduce the
      change of race condition here.
      
      /reviewed-on nexedi/slapos.core!82
      d4d89cce
    • Jérome Perrin's avatar
      Implement Software Destruction in slapos proxy · f01afc72
      Jérome Perrin authored
      Slapos proxy was not really deleting the software, just removing it from its database but not telling the node that requester requested deletion.
      
      As a result, node was not destroying the software and leaving the software folder around.
      
      These changes are about telling the node that requester wanted destruction of software, so that node really delete the folder.
      
      /reviewed-on nexedi/slapos.core!76
      f01afc72
    • Jérome Perrin's avatar
      tests/slapproxy: give more time to slapproxy to start · a92ef82b
      Jérome Perrin authored
      Tests are sometimes failing with:
      
      ```
      ======================================================================
      FAIL: testForwardToMasterInList (slapos.tests.slapproxy.TestMultiMasterSupport)
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/srv/slapgrid/slappart9/srv/testnode/byq/inst/test0-0/parts/slapos.core/slapos/tests/slapproxy/__init__.py", line 1003, in setUp
          self.startExternalProxy()
        File "/srv/slapgrid/slappart9/srv/testnode/byq/inst/test0-0/parts/slapos.core/slapos/tests/slapproxy/__init__.py", line 1050, in startExternalProxy
          self.fail('Could not start external proxy.')
      AssertionError: Could not start external proxy.
      
      ```
      
      especially on `COMP-2203-3Nodes-ERP5PROJECT2`. I logged on that machine and check the tests, it was really a problem that this slapproxy needs more than the `(20 * .1) = 2` seconds this tests waits before concluding that slap proxy could not start.
      
      Change the waiting loop to wait more each time. With this approach the max waiting time is 20 seconds.
      
      /reviewed-on !83
      a92ef82b
  5. 26 Dec, 2018 2 commits
  6. 21 Dec, 2018 2 commits